S3 exporter: endpoint documentation / bucket

[dmitryax]

Discussed in #32766

^{Originally posted by dabcoder April 30, 2024}
The S3 exporter documentation states that the endpoint parameter overrides the endpoint used by the exporter instead of constructing it from region and s3_bucket .

Yet in the code there is:

if c.S3Uploader.S3Bucket == "" {
  errs = multierr.Append(errs, errors.New("bucket is required"))
}

However, when the endpoint is provided, it should also contain the S3 bucket, thus I would not expect the s3_bucket to have to be provided and this error to be returned. Am I misunderstanding the config setup here?

[github-actions]

Pinging code owners for exporter/awss3: @atoulme @pdelewski. See Adding Labels via Comments if you do not have permissions to add labels yourself.

[atoulme]

This is because in some cases (minIO, storJ) I believe the endpoint can be completely different from what s3 expects, and the bucket is dropped.

Yes, we can make bucket required only if endpoint is not set.

[github-actions]

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

• exporter/awss3: @atoulme @pdelewski

See Adding Labels via Comments if you do not have permissions to add labels yourself.

[atoulme]

I think this was addressed by #32815. Closing.