Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[exporter/awss3] When using encoding extension, file format extension should be configurable #31818

Closed
adcharre opened this issue Mar 18, 2024 · 5 comments
Assignees
Labels
enhancement New feature or request exporter/awss3

Comments

@adcharre
Copy link
Contributor

Component(s)

exporter/awss3

Describe the issue you're reporting

When using the new encoding extension option to marshal data introduced in PR #31801, the generated key contains the ID of the extension. This can be long and contain characters that either don't make sense for a file extension or could be invalid for an S3 key.
For example given an extension defined in the config file as:

extension:
   textencoding/myspecialtextencoding:

A key would be generated similar to the following:
mytrace/year=2024/month=03/day=18/hour=12/minute=02/myprefixtrace_12345.textencoding/myspecialtextencoding

(where keyprefix=mytrace, prefix=myprefix and metadata=trace)

A better approach would be to allow the user to specify the required extension as part of the AWS S3 configuration or to have no extension at all.

@adcharre adcharre added the needs triage New item requiring triage label Mar 18, 2024
Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@crobert-1
Copy link
Member

Removing needs triage, code owner requested this issue be filed originally, and has approved PR.

Thanks for filing and making the change @adcharre!

@crobert-1 crobert-1 added enhancement New feature or request and removed needs triage New item requiring triage labels Mar 19, 2024
djaglowski pushed a commit that referenced this issue Mar 26, 2024
…ding (#31833)

**Description:** Modify the behaviour of the exporter when using an
encoding extension to add a user defined file extension or no extension
at all if not configured.

**Link to tracking Issue:** #31818

**Testing:** Unit tests

**Documentation:** Added details of new configuration option.
Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label May 22, 2024
@crobert-1
Copy link
Member

Can this issue be closed? It looks like it's been resolved by #31833.

@github-actions github-actions bot removed the Stale label May 23, 2024
@adcharre
Copy link
Contributor Author

Can this issue be closed? It looks like it's been resolved by #31833.

Closing, as indeed fixed by that PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request exporter/awss3
Projects
None yet
Development

No branches or pull requests

2 participants