Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pkg/stanza] update module go.uber.org/zap to v1.27.0 breaks tests #31442

Closed
songy23 opened this issue Feb 27, 2024 · 2 comments · Fixed by #31434
Closed

[pkg/stanza] update module go.uber.org/zap to v1.27.0 breaks tests #31442

songy23 opened this issue Feb 27, 2024 · 2 comments · Fixed by #31434
Assignees
@djaglowski
Labels
dependency issue pkg/stanza

Comments

@songy23
Copy link
Member

songy23 commented Feb 27, 2024

Component(s)

pkg/stanza

Describe the issue you're reporting

Related to #31434. pkg/stanza/errors/error_test.go breaks after the dependency update. See https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/8065563978/job/22031783400?pr=31434.
@songy23 songy23 mentioned this issue Feb 27, 2024
Merged
1 task
@github-actions GitHub Actions
Copy link
Contributor

Pinging code owners for pkg/stanza: @djaglowski. See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions GitHub Actions
Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@djaglowski djaglowski self-assigned this Feb 27, 2024
@songy23 songy23 removed the needs triage New item requiring triage label Feb 27, 2024
djaglowski added a commit that referenced this issue Feb 27, 2024
@renovate @opentelemetrybot @djaglowski
fix(deps): update module go.uber.org/zap to v1.27.0 (#31434)
7fa5060 
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [go.uber.org/zap](https://togithub.com/uber-go/zap) | `v1.26.0` ->
`v1.27.0` |
[![age](https://developer.mend.io/api/mc/badges/age/go/go.uber.org%2fzap/v1.27.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/go/go.uber.org%2fzap/v1.27.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/go/go.uber.org%2fzap/v1.26.0/v1.27.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/go/go.uber.org%2fzap/v1.26.0/v1.27.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>uber-go/zap (go.uber.org/zap)</summary>

### [`v1.27.0`](https://togithub.com/uber-go/zap/releases/tag/v1.27.0)

[Compare
Source](https://togithub.com/uber-go/zap/compare/v1.26.0...v1.27.0)

Enhancements:

-   [#&#8203;1378][]: Add `WithLazy` method for `SugaredLogger`.
- [#&#8203;1399][]: zaptest: Add `NewTestingWriter` for customizing
TestingWriter with more flexibility than `NewLogger`.
- [#&#8203;1406][]: Add `Log`, `Logw`, `Logln` methods for
`SugaredLogger`.
-   [#&#8203;1416][]: Add `WithPanicHook` option for testing panic logs.

Thanks to [@&#8203;defval](https://togithub.com/defval),
[@&#8203;dimmo](https://togithub.com/dimmo),
[@&#8203;arxeiss](https://togithub.com/arxeiss), and
[@&#8203;MKrupauskas](https://togithub.com/MKrupauskas) for their
contributions to this release.

[#&#8203;1378]: https://togithub.com/uber-go/zap/pull/1378

[#&#8203;1399]: https://togithub.com/uber-go/zap/pull/1399

[#&#8203;1406]: https://togithub.com/uber-go/zap/pull/1406

[#&#8203;1416]: https://togithub.com/uber-go/zap/pull/1416

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any
time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/open-telemetry/opentelemetry-collector-contrib).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yMTIuMCIsInVwZGF0ZWRJblZlciI6IjM3LjIxMi4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

Closes #31442

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: opentelemetrybot <107717825+opentelemetrybot@users.noreply.github.com>
Co-authored-by: Dan Jaglowski <jaglows3@gmail.com>
This was referenced Mar 5, 2024
Closed
Open
XinRanZhAWS pushed a commit to XinRanZhAWS/opentelemetry-collector-contrib that referenced this issue Mar 13, 2024
@renovate @opentelemetrybot
@djaglowski @XinRanZhAWS
fix(deps): update module go.uber.org/zap to v1.27.0 (open-telemetry#3…
d813814 
…1434)

[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [go.uber.org/zap](https://togithub.com/uber-go/zap) | `v1.26.0` ->
`v1.27.0` |
[![age](https://developer.mend.io/api/mc/badges/age/go/go.uber.org%2fzap/v1.27.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/go/go.uber.org%2fzap/v1.27.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/go/go.uber.org%2fzap/v1.26.0/v1.27.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/go/go.uber.org%2fzap/v1.26.0/v1.27.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>uber-go/zap (go.uber.org/zap)</summary>

### [`v1.27.0`](https://togithub.com/uber-go/zap/releases/tag/v1.27.0)

[Compare
Source](https://togithub.com/uber-go/zap/compare/v1.26.0...v1.27.0)

Enhancements:

-   [#&open-telemetry#8203;1378][]: Add `WithLazy` method for `SugaredLogger`.
- [#&open-telemetry#8203;1399][]: zaptest: Add `NewTestingWriter` for customizing
TestingWriter with more flexibility than `NewLogger`.
- [#&open-telemetry#8203;1406][]: Add `Log`, `Logw`, `Logln` methods for
`SugaredLogger`.
-   [#&open-telemetry#8203;1416][]: Add `WithPanicHook` option for testing panic logs.

Thanks to [@&open-telemetry#8203;defval](https://togithub.com/defval),
[@&open-telemetry#8203;dimmo](https://togithub.com/dimmo),
[@&open-telemetry#8203;arxeiss](https://togithub.com/arxeiss), and
[@&open-telemetry#8203;MKrupauskas](https://togithub.com/MKrupauskas) for their
contributions to this release.

[#&open-telemetry#8203;1378]: https://togithub.com/uber-go/zap/pull/1378

[#&open-telemetry#8203;1399]: https://togithub.com/uber-go/zap/pull/1399

[#&open-telemetry#8203;1406]: https://togithub.com/uber-go/zap/pull/1406

[#&open-telemetry#8203;1416]: https://togithub.com/uber-go/zap/pull/1416

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any
time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/open-telemetry/opentelemetry-collector-contrib).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yMTIuMCIsInVwZGF0ZWRJblZlciI6IjM3LjIxMi4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

Closes open-telemetry#31442

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: opentelemetrybot <107717825+opentelemetrybot@users.noreply.github.com>
Co-authored-by: Dan Jaglowski <jaglows3@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@djaglowski djaglowski

Labels
dependency issue pkg/stanza
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(deps): update module go.uber.org/zap to v1.27.0 open-telemetry/opentelemetry-collector-contrib
2 participants
@djaglowski @songy23