Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[receiver/filelog] Document includes/excludes #31229

Closed
atoulme opened this issue Feb 13, 2024 · 1 comment · Fixed by #31261
Closed

[receiver/filelog] Document includes/excludes #31229

atoulme opened this issue Feb 13, 2024 · 1 comment · Fixed by #31261
Labels
enhancement New feature or request receiver/filelog

Comments

@atoulme
Copy link
Contributor

atoulme commented Feb 13, 2024

Component(s)

receiver/filelog

Is your feature request related to a problem? Please describe.

filelogreceiver has both an includes an excludes parameter. We should document how these interact.

Describe the solution you'd like

Take the logic defined in

func FindFiles(includes []string, excludes []string) ([]string, error) {
and the tests defined in https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/pkg/stanza/fileconsumer/matcher/internal/finder/finder_test.go#L57 and use them as basis for additional documentation of the receiver or stanza config to make it possible for end users to create the right filters.

Describe alternatives you've considered

No response

Additional context

No response

@atoulme atoulme added enhancement New feature or request needs triage New item requiring triage labels Feb 13, 2024
Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request receiver/filelog
Projects
None yet
2 participants