Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[receiver/purefareceiver] Remove mock implementation of component.Host #30599

Closed
Tracked by #30501
atoulme opened this issue Jan 16, 2024 · 2 comments · Fixed by #31102 or #31103
Closed
Tracked by #30501

[receiver/purefareceiver] Remove mock implementation of component.Host #30599

atoulme opened this issue Jan 16, 2024 · 2 comments · Fixed by #31102 or #31103
Assignees
@dgoscn
Labels
bug Something isn't working receiver/purefa

Comments

@atoulme
Copy link
Contributor

atoulme commented Jan 16, 2024

Component(s)

receiver/purefa

Describe the issue you're reporting

Remove mock host implementation in receiver/purefareceiver/internal/bearertoken_test.go and consider using componenttest.NewNopHost().
@atoulme atoulme added the needs triage New item requiring triage label Jan 16, 2024
@atoulme atoulme mentioned this issue Jan 16, 2024
Closed
21 tasks
@github-actions GitHub Actions
Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@crobert-1 crobert-1 added bug Something isn't working and removed needs triage New item requiring triage labels Jan 16, 2024
@github-actions github-actions bot mentioned this issue Jan 23, 2024
Closed
@jpkrohling
Copy link
Member

@dgoscn , can you work on this one?

This was referenced Feb 7, 2024
Merged
Merged
mx-psi pushed a commit that referenced this issue Feb 8, 2024
@atoulme
[chore] Remove use of ReportFatalError (#31103)
94889fb 
**Description:**
Remove use of `ReportFatalError` in mock host.

Fixes #30599
mx-psi pushed a commit that referenced this issue Feb 8, 2024
@atoulme
[chore] Remove ReportFatalError use in host mock (#31102)
80c739f 
**Description:** 
Remove `ReportFatalError` use in host mock

Fixes #30599
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dgoscn dgoscn

Labels
bug Something isn't working receiver/purefa
Projects
None yet
Milestone
No milestone
4 participants
@jpkrohling @atoulme @dgoscn @crobert-1