Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CDCD] Investigate why goimports liter isn't firing for lifecycle generated tests #30439

Open
dmitryax opened this issue Jan 11, 2024 · 5 comments
Open

[CDCD] Investigate why goimports liter isn't firing for lifecycle generated tests #30439

dmitryax opened this issue Jan 11, 2024 · 5 comments
Assignees
@codeboten
Labels
bug Something isn't working ci-cd CI, CD, testing, build issues good first issue Good for newcomers help wanted Extra attention is needed

Comments

@dmitryax
Copy link
Member

dmitryax commented Jan 11, 2024 •
edited
Loading

The tests are generated with not aligned imports, but there are no linter complaints. See #30419 as an example.

Investigate why it's happening and propose a solution.
@dmitryax dmitryax added bug Something isn't working help wanted Extra attention is needed good first issue Good for newcomers ci-cd CI, CD, testing, build issues labels Jan 11, 2024
@dmitryax dmitryax mentioned this issue Jan 11, 2024
Open
@codeboten codeboten self-assigned this Jan 11, 2024
codeboten pushed a commit to codeboten/opentelemetry-collector-contrib that referenced this issue Jan 11, 2024
[chore] enable gci on generated code
3408b10 
This prevents us from having a bunch of code in the repo that isn't compliant w/ the import rules we have enabled.

Fixes open-telemetry#30439

Signed-off-by: Alex Boten <aboten@lightstep.com>
@codeboten codeboten mentioned this issue Jan 11, 2024
Closed
@codeboten
Copy link
Contributor

gci skips generated code by default. I've submitted a PR to enable it, not sure how much still will break though 😓

@github-actions github-actions bot mentioned this issue Jan 16, 2024
Closed
@braydonk
Copy link
Contributor

braydonk commented Feb 1, 2024

I just ran into this. I was trying to run make gogci to update my PR, but it caught all of those generated files as well. So I'm confused to see that apparently gci skips generated code by default, because my problem is that it's running on generated code I don't want to touch in my PR. 😅

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 2, 2024

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

@github-actions github-actions bot added the Stale label Apr 2, 2024
@codeboten codeboten removed the Stale label Apr 5, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 5, 2024

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

@github-actions github-actions bot added the Stale label Jun 5, 2024
@codeboten codeboten removed the Stale label Jun 6, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 6, 2024

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

@github-actions github-actions bot added the Stale label Aug 6, 2024
@dmitryax dmitryax removed the Stale label Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@codeboten codeboten

Labels
bug Something isn't working ci-cd CI, CD, testing, build issues good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[chore] enable gci on generated code codeboten/opentelemetry-collector-contrib
3 participants
@codeboten @dmitryax @braydonk