-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unable to upgrade to upload-artifact
and download-artifact
to v4
#30102
Labels
bug
Something isn't working
ci-cd
CI, CD, testing, build issues
help wanted
Extra attention is needed
priority:p1
High
Comments
TylerHelmuth
added
bug
Something isn't working
help wanted
Extra attention is needed
priority:p1
High
ci-cd
CI, CD, testing, build issues
labels
Dec 19, 2023
This was referenced Dec 19, 2023
TylerHelmuth
changed the title
Unable to upgrade to upload-artifact v4
Unable to upgrade to upload-artifact and download-artifact to v4
Dec 19, 2023
TylerHelmuth
changed the title
Unable to upgrade to upload-artifact and download-artifact to v4
Unable to upgrade to Dec 19, 2023
upload-artifact
and download-artifact
to v4
TylerHelmuth
added a commit
that referenced
this issue
Dec 19, 2023
May be related to actions/upload-artifact#480 |
1 task
This was referenced Dec 19, 2023
cparkins
pushed a commit
to AmadeusITGroup/opentelemetry-collector-contrib
that referenced
this issue
Jan 10, 2024
This was referenced Jan 25, 2024
Closed
codeboten
pushed a commit
that referenced
this issue
Feb 13, 2024
…act` to `v4` (#31236) The upgrade of `actions/upload-artifact` and `actions/download-artifact` is a breaking change. 1. Both actions need to be upgraded together, as downloading artifacts uploaded with previous version does not work. 2. A breaking change in `upload-artifact` is that you cannot upload to the same artifact name twice. The second point lead to the changes in this pull request. I have modified the names of artifacts to hopefully prevent conflicts. **Link to tracking Issue:** #30102 **Testing:** The changes to the `build-and-test` and `e2e-test` workflows are tested in this PR's checks. The changes to the `load-test` workflow can only be tested after merging to main, I'm afraid, as this is when this workflow is triggered.
Fixed in #31236 |
XinRanZhAWS
pushed a commit
to XinRanZhAWS/opentelemetry-collector-contrib
that referenced
this issue
Mar 13, 2024
…act` to `v4` (open-telemetry#31236) The upgrade of `actions/upload-artifact` and `actions/download-artifact` is a breaking change. 1. Both actions need to be upgraded together, as downloading artifacts uploaded with previous version does not work. 2. A breaking change in `upload-artifact` is that you cannot upload to the same artifact name twice. The second point lead to the changes in this pull request. I have modified the names of artifacts to hopefully prevent conflicts. **Link to tracking Issue:** open-telemetry#30102 **Testing:** The changes to the `build-and-test` and `e2e-test` workflows are tested in this PR's checks. The changes to the `load-test` workflow can only be tested after merging to main, I'm afraid, as this is when this workflow is triggered.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working
ci-cd
CI, CD, testing, build issues
help wanted
Extra attention is needed
priority:p1
High
What happened?
When we bumped to
upload-artifact@v4
anddownload-artifact@v4
our CI started failing. I think it is related to actions/upload-artifact#471 but I'm not entirely sure. We need to investigate what we are doing that no longer works inv4
.Related to #30098
The text was updated successfully, but these errors were encountered: