Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[exporter/datadog] Migrate logs exporter from HTTP client to logs agent #30099

Closed
songy23 opened this issue Dec 19, 2023 · 4 comments · Fixed by #32327
Closed

[exporter/datadog] Migrate logs exporter from HTTP client to logs agent #30099

songy23 opened this issue Dec 19, 2023 · 4 comments · Fixed by #32327
Labels
data:logs Logs related issues dependency issue enhancement New feature or request exporter/datadog Datadog components never stale Issues marked with this label will be never staled and automatically removed priority:p2 Medium

Comments

@songy23
Copy link
Member

songy23 commented Dec 19, 2023 •
edited
Loading

Component(s)

exporter/datadog

What happened?

This is a tracking issue on the ongoing refactor of the Datadog logs exporter. Currently the Datadog logs exporter uses the HTTP client to send logs and the HTTP client has some issues, e.g. when attributes a.b.c and a.b are both sent, a.b gets overridden. We want to refactor the logs agent in Datadog-agent and use it in Datadog logs exporter instead.

Collector version

mainline

Environment information

No response

OpenTelemetry Collector configuration

No response

Log output

No response

Additional context

No response
@songy23 songy23 added bug Something isn't working enhancement New feature or request exporter/datadog Datadog components dependency issue data:logs Logs related issues labels Dec 19, 2023
@songy23
Copy link
Member Author

songy23 commented Dec 19, 2023

@liustanley is working on this (looks like I cannot assign this issue to you, so just an FYI)

@songy23 songy23 mentioned this issue Dec 19, 2023
Closed
@github-actions github-actions bot mentioned this issue Dec 26, 2023
Closed
@github-actions GitHub Actions
Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Feb 19, 2024
@mx-psi
Copy link
Member

mx-psi commented Mar 8, 2024

@liustanley @songy23 any updates on this issue?

@songy23
Copy link
Member Author

songy23 commented Mar 8, 2024

This is still ongoing, added priority.

@songy23 songy23 added priority:p2 Medium never stale Issues marked with this label will be never staled and automatically removed and removed bug Something isn't working Stale labels Mar 8, 2024
@songy23 songy23 mentioned this issue Apr 23, 2024
Merged
mx-psi added a commit that referenced this issue May 6, 2024
@liustanley @mx-psi
[exporter/datadog] Refactor Datadog Exporter to use logs agent export…
b270022 
…er (#32327)

**Description:** <Describe what has changed.>
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
This PR adds support for the logs agent exporter in order to export logs
to Datadog. The following changes were made in order to support this:
- Update datadog-agent modules to the following commit hash version:
DataDog/datadog-agent@a1ef7ed
- Remove `peer_service_aggregation` config option which was deprecated
and removed since last datadog-agent version:
DataDog/datadog-agent#23284
- Add logs agent exporter setup in datadog exporter factory. This is
disabled by default and can be enabled via feature gate.

**Link to tracking Issue:** 

Fixes
#30099

**Testing:** <Describe what testing was performed and which tests were
added.>

**Documentation:** <Describe the documentation added.>

---------

Co-authored-by: Pablo Baeyens <pbaeyens31+github@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
data:logs Logs related issues dependency issue enhancement New feature or request exporter/datadog Datadog components never stale Issues marked with this label will be never staled and automatically removed priority:p2 Medium
Projects
None yet
Milestone
No milestone
2 participants
@mx-psi @songy23