Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[exporter/honeycombmarker] Set user-agent header #29894

Closed
TylerHelmuth opened this issue Dec 14, 2023 · 0 comments · Fixed by #29912
Closed

[exporter/honeycombmarker] Set user-agent header #29894

TylerHelmuth opened this issue Dec 14, 2023 · 0 comments · Fixed by #29912
Assignees
@JaredTan95
Labels
enhancement New feature or request exporter/honeycombmarker

Comments

@TylerHelmuth
Copy link
Member

Component(s)

exporter/honeycombmarker

Is your feature request related to a problem? Please describe.

The Honeycomb Marker exporter doesn't set the User-Agent header in the outgoing HTTP requests it makes, but it should.

Describe the solution you'd like

Following the pattern set in the otlphttpexporter, it should use fmt.Sprintf("%s/%s (%s/%s)", set.BuildInfo.Description, set.BuildInfo.Version, runtime.GOOS, runtime.GOARCH) as the user agent value.

Describe alternatives you've considered

No response

Additional context

No response
@TylerHelmuth TylerHelmuth added enhancement New feature or request needs triage New item requiring triage exporter/honeycombmarker and removed needs triage New item requiring triage labels Dec 14, 2023
@JaredTan95 JaredTan95 mentioned this issue Dec 15, 2023
Merged
@JaredTan95 JaredTan95 self-assigned this Dec 15, 2023
TylerHelmuth pushed a commit that referenced this issue Dec 18, 2023
@JaredTan95
[exporter/honeycombmarker] Set user-agent header (#29912)
80c69e6 
**Description:** <Describe what has changed.>
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->

**Link to tracking Issue:** close
#29894

**Testing:** <Describe what testing was performed and which tests were
added.>

**Documentation:** <Describe the documentation added.>

---------

Signed-off-by: Jared Tan <jian.tan@daocloud.io>
@github-actions github-actions bot mentioned this issue Dec 19, 2023
Closed
cparkins pushed a commit to AmadeusITGroup/opentelemetry-collector-contrib that referenced this issue Jan 10, 2024
@JaredTan95 @cparkins
[exporter/honeycombmarker] Set user-agent header (open-telemetry#29912)
b27759a 
**Description:** <Describe what has changed.>
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->

**Link to tracking Issue:** close
open-telemetry#29894

**Testing:** <Describe what testing was performed and which tests were
added.>

**Documentation:** <Describe the documentation added.>

---------

Signed-off-by: Jared Tan <jian.tan@daocloud.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JaredTan95 JaredTan95

Labels
enhancement New feature or request exporter/honeycombmarker
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[exporter/honeycombmarker] Set user-agent header JaredTan95/opentelemetry-collector-contrib
2 participants
@TylerHelmuth @JaredTan95