Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Azure Event Hub Receiver: Update Metric Documentation #28622

Closed
cparkins opened this issue Oct 25, 2023 · 3 comments
Closed

Azure Event Hub Receiver: Update Metric Documentation #28622

cparkins opened this issue Oct 25, 2023 · 3 comments
Labels
documentation Improvements or additions to documentation receiver/azureeventhub

Comments

@cparkins
Copy link
Contributor

Component(s)

receiver/azureeventhub

Describe the issue you're reporting

It appears that the documentation surrounding the Metrics created by the Azure Event Hub Receiver is out of date when compared to that of Logs. This documentation should be updated to include the fields that the Metrics values are being converted to. In addition the data regarding how the Metrics are created should also be updated to reflect what the code is actually doing.
@cparkins cparkins added the needs triage New item requiring triage label Oct 25, 2023
@github-actions
Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@cparkins cparkins mentioned this issue Oct 25, 2023
Merged
@atoulme atoulme removed the needs triage New item requiring triage label Oct 25, 2023
djaglowski pushed a commit that referenced this issue Oct 26, 2023
@cparkins
[chore] Update Azure Event Hub Receiver Documentation (#28623)
14d6d67 
**Description:** <Describe what has changed.>
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
The Documentation surrounding Azure Event Hub Metric creation is
out-of-date or not accurate.

**Link to tracking Issue:** <Issue number if applicable>

#28622

**Testing:** <Describe what testing was performed and which tests were
added.>
No code was modified, only documentation.

**Documentation:** <Describe the documentation added.>
Updated the README.md in reciever/azureeventhub to be more accurate and
improved the Metric mapping table to be consistent with the Log section.
@crobert-1 crobert-1 added the documentation Improvements or additions to documentation label Oct 26, 2023
@crobert-1
Copy link
Member

@cparkins I see your PR has been merged. Can we mark this issue as complete, or is there more left to do here?

@cparkins
Copy link
Contributor Author

Yes, I don't know of any other issues with the updated documentation.

sigilioso pushed a commit to carlossscastro/opentelemetry-collector-contrib that referenced this issue Oct 27, 2023
@cparkins @sigilioso
[chore] Update Azure Event Hub Receiver Documentation (open-telemetry…
03868a3 
…#28623)

**Description:** <Describe what has changed.>
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
The Documentation surrounding Azure Event Hub Metric creation is
out-of-date or not accurate.

**Link to tracking Issue:** <Issue number if applicable>

open-telemetry#28622

**Testing:** <Describe what testing was performed and which tests were
added.>
No code was modified, only documentation.

**Documentation:** <Describe the documentation added.>
Updated the README.md in reciever/azureeventhub to be more accurate and
improved the Metric mapping table to be consistent with the Log section.
@github-actions github-actions bot mentioned this issue Oct 31, 2023
Closed
jmsnll pushed a commit to jmsnll/opentelemetry-collector-contrib that referenced this issue Nov 12, 2023
@cparkins @jmsnll
[chore] Update Azure Event Hub Receiver Documentation (open-telemetry…
5393d4c 
…#28623)

**Description:** <Describe what has changed.>
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
The Documentation surrounding Azure Event Hub Metric creation is
out-of-date or not accurate.

**Link to tracking Issue:** <Issue number if applicable>

open-telemetry#28622

**Testing:** <Describe what testing was performed and which tests were
added.>
No code was modified, only documentation.

**Documentation:** <Describe the documentation added.>
Updated the README.md in reciever/azureeventhub to be more accurate and
improved the Metric mapping table to be consistent with the Log section.
RoryCrispin pushed a commit to ClickHouse/opentelemetry-collector-contrib that referenced this issue Nov 24, 2023
@cparkins @RoryCrispin
[chore] Update Azure Event Hub Receiver Documentation (open-telemetry…
544655d 
…#28623)

**Description:** <Describe what has changed.>
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
The Documentation surrounding Azure Event Hub Metric creation is
out-of-date or not accurate.

**Link to tracking Issue:** <Issue number if applicable>

open-telemetry#28622

**Testing:** <Describe what testing was performed and which tests were
added.>
No code was modified, only documentation.

**Documentation:** <Describe the documentation added.>
Updated the README.md in reciever/azureeventhub to be more accurate and
improved the Metric mapping table to be consistent with the Log section.
@github-actions github-actions bot mentioned this issue Jul 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation receiver/azureeventhub
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@atoulme @cparkins @crobert-1