Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capability to filter span links #26660

Closed
fujin opened this issue Sep 12, 2023 · 8 comments
Closed

Capability to filter span links #26660

fujin opened this issue Sep 12, 2023 · 8 comments
Assignees

Comments

@fujin
Copy link

fujin commented Sep 12, 2023

Component(s)

processor/filter

Is your feature request related to a problem? Please describe.

Some of my legacy code (difficult/impossible to change) emits OpenTracing span links (via opentracing-shim for opentelemetry) using the e..g asChildOf(parentSpan) API.

Unfortunately for me, these links were not implemented correctly and link to spans within the same trace. I'd like to be able to filter drop them so that I do not send them to my tracing vendor.

Describe the solution you'd like

Similar to filtering of span events, allow filtering of span links.

Describe alternatives you've considered

Patch the legacy code 🙃

Additional context

No response

@fujin fujin added enhancement New feature or request needs triage New item requiring triage labels Sep 12, 2023
@github-actions github-actions bot added the processor/transform Transform processor label Sep 12, 2023
@github-actions
Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@TylerHelmuth TylerHelmuth added priority:p2 Medium pkg/ottl processor/filter Filter processor and removed needs triage New item requiring triage processor/transform Transform processor labels Sep 12, 2023
@TylerHelmuth
Copy link
Member

@fujin thanks for raising this issue. We purposefully omitted a ottlspanlink context when we created the concept because we had no use case, but now we do.

The context would be very similar to ottlspanevent. @evan-bradley I am good with this new context, are you?

@TylerHelmuth TylerHelmuth added the help wanted Extra attention is needed label Sep 20, 2023
@TylerHelmuth TylerHelmuth removed the help wanted Extra attention is needed label Oct 11, 2023
fujin pushed a commit to fujin/opentelemetry-collector-contrib that referenced this issue Nov 7, 2023
Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Aug 19, 2024
Copy link
Contributor

This issue has been closed as inactive because it has been stale for 120 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants