Skip to content

[pkg/translator/jaeger] Bump github.com/jaegertracing/jaeger from 1.41.0 to 1.49.0 broke tests #26567

Closed
@songy23

Description

Component(s)

pkg/translator/jaeger

What happened?

See https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/6147608956/job/16679659646?pr=26563

go test -race -timeout 300s -parallel 4 --tags="" -cover ./... -covermode=atomic -args -test.gocoverdir="/home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/coverage/unit"
--- FAIL: TestProtoToTraces (0.01s)
    --- FAIL: TestProtoToTraces/two-spans-with-follower (0.00s)
        jaegerproto_to_traces_test.go:313: 
            	Error Trace:	/home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/pkg/translator/jaeger/jaegerproto_to_traces_test.go:313
            	Error:      	Not equal: 
            	            	expected: ptrace.Traces{orig:(*v1.ExportTraceServiceRequest)(0xc000013440)}
            	            	actual  : ptrace.Traces{orig:(*v1.ExportTraceServiceRequest)(0xc000013638)}
            	            	
            	            	Diff:
            	            	--- Expected
            	            	+++ Actual
            	            	@@ -70,3 +70,3 @@
            	            	         ParentSpanId: (data.SpanID) (len=8) {
            	            	-         00000000  00 00 00 00 00 00 00 00                           |........|
            	            	+         00000000  af ae ad ac ab aa a9 a8                           |........|
            	            	         },
            	Test:       	TestProtoToTraces/two-spans-with-follower
    --- FAIL: TestProtoToTraces/a-spans-with-two-parent (0.00s)
        jaegerproto_to_traces_test.go:313: 
            	Error Trace:	/home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/pkg/translator/jaeger/jaegerproto_to_traces_test.go:313
            	Error:      	Not equal: 
            	            	expected: ptrace.Traces{orig:(*v1.ExportTraceServiceRequest)(0xc000013458)}
            	            	actual  : ptrace.Traces{orig:(*v1.ExportTraceServiceRequest)(0xc000013878)}
            	            	
            	            	Diff:
            	            	--- Expected
            	            	+++ Actual
            	            	@@ -70,3 +70,3 @@
            	            	         ParentSpanId: (data.SpanID) (len=8) {
            	            	-         00000000  00 00 00 00 00 00 00 00                           |........|
            	            	+         00000000  af ae ad ac ab aa a9 a8                           |........|
            	            	         },
            	Test:       	TestProtoToTraces/a-spans-with-two-parent
FAIL

Collector version

mainline

Environment information

No response

OpenTelemetry Collector configuration

No response

Log output

No response

Additional context

No response

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions