Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] k8s e2e test enhancement #26068

Open
3 tasks
fatsheep9146 opened this issue Aug 23, 2023 · 7 comments
Open
3 tasks

[chore] k8s e2e test enhancement #26068

fatsheep9146 opened this issue Aug 23, 2023 · 7 comments
Labels
cmd/telemetrygen telemetrygen command enhancement New feature or request internal/k8stest never stale Issues marked with this label will be never staled and automatically removed

Comments

@fatsheep9146
Copy link
Contributor

fatsheep9146 commented Aug 23, 2023

Component(s)

internal/k8stest

Is your feature request related to a problem? Please describe.

The k8s e2e testing module encountered a critical bug #25849 a few days ago, which caused many CI processes to fail and significantly impacted the release schedule of the entire project. Although the root cause of the problem has been identified #25889 (though it is not a solution to all issues), this incident highlighted the need for enhancements in the e2e module.

  • On one hand, we need to reduce the probability of similar issues occurring again,
  • On the other hand, we should preserve more context to troubleshoot flaky tests if they occur again.

So I open this issue to track some follow-ups needed to enhance the e2e test, some of them is already discussed in slack channel

here are some follow-ups I came up

  • add e2e test for telemetrygen
  • add more error log or event when collector could not start in time
  • add more error log or event when telemetrygen could not start in time

Describe alternatives you've considered

No response

Additional context

No response

@fatsheep9146 fatsheep9146 added enhancement New feature or request needs triage New item requiring triage labels Aug 23, 2023
@github-actions
Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@crobert-1
Copy link
Member

crobert-1 commented Aug 23, 2023

/label cmd/telemetrygen

@github-actions github-actions bot added the cmd/telemetrygen telemetrygen command label Aug 23, 2023
@TylerHelmuth
Copy link
Member

I don't really want to add e2e tests for telemetrygen since its a utility, but they would've caught this issue so it is probably the optimal solution. If we can get a good enough solution with better logging/events in the k8s e2e tests I am good with that.

@crobert-1
Copy link
Member

/label -needs-triage

@github-actions
Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Oct 31, 2023
@crobert-1 crobert-1 added never stale Issues marked with this label will be never staled and automatically removed and removed Stale labels Oct 31, 2023
@atoulme
Copy link
Contributor

atoulme commented Mar 13, 2024

We at least have some support for regression testing with #26668 now, can we close this or maybe split this issue?

@TylerHelmuth
Copy link
Member

@atoulme agreed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cmd/telemetrygen telemetrygen command enhancement New feature or request internal/k8stest never stale Issues marked with this label will be never staled and automatically removed
Projects
None yet
Development

No branches or pull requests

4 participants