Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Carbon receiver leaks obsrecv operations #24275

Closed
atoulme opened this issue Jul 14, 2023 · 1 comment · Fixed by #24276
Closed

Carbon receiver leaks obsrecv operations #24275

atoulme opened this issue Jul 14, 2023 · 1 comment · Fixed by #24276
Labels
bug Something isn't working receiver/carbon

Comments

@atoulme
Copy link
Contributor

atoulme commented Jul 14, 2023 •
edited
Loading

See #21484 (comment)_ for original report

The carbonreceiver has a memory leak where it will repeatedly open new obsrecv operations but not close them afterwards. Those operations eventually create a burden.

The fix is to make sure the receiver only creates an operation per interaction over TCP.
@atoulme atoulme added receiver/carbon bug Something isn't working labels Jul 14, 2023
@github-actions
Copy link
Contributor

Pinging code owners for receiver/carbon: @aboguszewski-sumo. See Adding Labels via Comments if you do not have permissions to add labels yourself.

@atoulme atoulme mentioned this issue Jul 14, 2023
Merged
mx-psi pushed a commit that referenced this issue Aug 8, 2023
@atoulme
[receiver/carbon] Fix memory leak (#24276)
e314b70 
**Description:** 
The carbonreceiver has a memory leak where it will repeatedly open new
obsrecv operations but not close them afterwards. Those operations
eventually create a burden.
  
The fix is to make sure the receiver only creates an operation per
interaction over TCP.

**Link to tracking Issue:**
Fixes #24275

**Testing:**
Added a test showing TCP reconnections no longer start additional spans.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working receiver/carbon
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[receiver/carbon] Fix memory leak atoulme/opentelemetry-collector-contrib
1 participant
@atoulme