[exporter/kafkaexporter] Support for configuring SASL handshake version #21074
Assignees
Labels
Comments
eduojeda
added
enhancement
|
Pinging code owners:
See Adding Labels via Comments if you do not have permissions to add labels yourself. |
eduojeda
changed the title
|
This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping Pinging code owners:
See Adding Labels via Comments if you do not have permissions to add labels yourself. |
MovieStoreGuy
pushed a commit
that referenced
this issue
Jul 11, 2023
…ersion (#21075) **Description:** Adds support for configuring SASL handshake version. The new parameter defaults to 0 just like Sarama, so the change should be backwards compatible. **Link to tracking Issue:** #21074 **Testing:** - Added a test for the check that the SASL version parameter is within the acceptable range - Built a custom collector and tested that the version setting works as expected. **Documentation:** - Updated the README file to document the new SASL configuration parameter.
|
The proposed changes have now been marged upstream. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Component(s)
exporter/kafka
Is your feature request related to a problem? Please describe.
The Kafka exporter is built on top of Shopify's sarama Kafka client. The sarama library defaults to using SASL handshake V0 (see here), but Kafka > 1.x uses SASL handshake V1. The library allows the version to be set via configuration, but the exporter does not expose this functionality. This leads to connection timeouts when trying to reach a Kafka > 1.x broker.
Describe the solution you'd like
The Kafka exporter should allow SASL users to configure the version as needed. This can easily be done through a new
exporters.kafka.auth.sasl.versionkey in the collector's YAML config. The value should default to 0 for backwards compatibility.Describe alternatives you've considered
No response
Additional context
We have already created a PR with the required changes. Furthermore, we have built and deployed a custom collector that successfully connects to our Kafka cluster using SASL handshake V1 via the proposed change.
The text was updated successfully, but these errors were encountered: