-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cmd/opampsupervisor] Implement Collector bootstrapping #21071
Comments
This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping |
**Description:** Utilize the OpAMP extension to get identifying attributes from the Collector. A few things I want to call out: * I moved the Supervisor's various config fragments into separate files that are embedded into the binary. I think this makes them easier to edit. I can also move the changes for the existing fragments to a separate PR if it adds too much to the diff. * I opted to use the OTLP receiver instead of the filelog receiver because it is included in both existing upstream distributions and I expect it is slightly more common. Ideally we should look at other approaches to solve this. **Link to tracking Issue:** Resolves #21071 **Testing:** Added an integration test. --------- Co-authored-by: Antoine Toulme <antoine@toulme.name> Co-authored-by: Evan Bradley <evan-bradley@users.noreply.github.com>
…ry#29848) **Description:** Utilize the OpAMP extension to get identifying attributes from the Collector. A few things I want to call out: * I moved the Supervisor's various config fragments into separate files that are embedded into the binary. I think this makes them easier to edit. I can also move the changes for the existing fragments to a separate PR if it adds too much to the diff. * I opted to use the OTLP receiver instead of the filelog receiver because it is included in both existing upstream distributions and I expect it is slightly more common. Ideally we should look at other approaches to solve this. **Link to tracking Issue:** Resolves open-telemetry#21071 **Testing:** Added an integration test. --------- Co-authored-by: Antoine Toulme <antoine@toulme.name> Co-authored-by: Evan Bradley <evan-bradley@users.noreply.github.com>
Component(s)
No response
Is your feature request related to a problem? Please describe.
The OpAMP Supervisor needs to support handling AgentDescription messages from the Collector to get the Collector's identifying attributes.
Describe the solution you'd like
The Supervisor should start the Collector with a basic config that includes the
opamp
extension and allows the Collector to send it this information. More details about this process can be found in the design document here.Describe alternatives you've considered
No response
Additional context
Depends on #16594.
The text was updated successfully, but these errors were encountered: