Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

spanmetricsconnector: Change metric name from latency to duration #19214

Closed
gouthamve opened this issue Mar 6, 2023 · 1 comment
Closed

spanmetricsconnector: Change metric name from latency to duration #19214

gouthamve opened this issue Mar 6, 2023 · 1 comment
Assignees
@kovrus
Labels
bug Something isn't working connector/spanmetrics

Comments

@gouthamve
Copy link
Member

Component(s)

connector/spanmetrics

What happened?

Description

open-telemetry/opentelemetry-specification#2977 (comment) got me thinking that metric name for the histogram should be duration and not latency. We don't use latency in any of our semantic conventions and this stands out.

Collector version

main

Environment information

No response

OpenTelemetry Collector configuration

No response

Log output

No response

Additional context

No response
@gouthamve gouthamve added bug Something isn't working needs triage New item requiring triage labels Mar 6, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Mar 6, 2023

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@gouthamve gouthamve changed the title Change metric name from latency to duration spanmetricsconnector: Change metric name from latency to duration Mar 6, 2023
@kovrus kovrus self-assigned this Mar 6, 2023
This was referenced Mar 6, 2023
Closed
Merged
@atoulme atoulme removed the needs triage New item requiring triage label Mar 7, 2023
@kovrus kovrus closed this as completed Mar 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kovrus kovrus

Labels
bug Something isn't working connector/spanmetrics
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@atoulme @gouthamve @kovrus