Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable the spanmetrics connector component. #18760

Closed
kovrus opened this issue Feb 17, 2023 · 5 comments
Closed

Enable the spanmetrics connector component. #18760

kovrus opened this issue Feb 17, 2023 · 5 comments

Comments

@kovrus
Copy link
Member

kovrus commented Feb 17, 2023

Component(s)

connector/spanmetrics

Describe the issue you're reporting

The spanmetrics connector is a port of the spanmetrics processor, but since it is going to be a new component, we thought that it can be a good time to fix some issues of the former spanmetrics processor in the new connector and bring the connector closer to the OTel spec, drop any related Prometheus specific conventions that the processor heavily uses, etc.

We can deprecate the processor and keep both components for some time to give users time to migrate. It should not be that critical anyways because the spanmetrics processor's stability level is in development.

TODO when enabling the component:

@kovrus kovrus added needs triage New item requiring triage connector/spanmetrics labels Feb 17, 2023
@github-actions
Copy link
Contributor

Pinging code owners for connector/spanmetrics: @albertteoh. See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions
Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@kovrus
Copy link
Member Author

kovrus commented Feb 17, 2023

cc: @Cluas @albertteoh @djaglowski

@kovrus kovrus added processor/spanmetrics Span Metrics processor and removed needs triage New item requiring triage labels Feb 17, 2023
@github-actions
Copy link
Contributor

Pinging code owners for processor/spanmetrics: @albertteoh. See Adding Labels via Comments if you do not have permissions to add labels yourself.

@kovrus kovrus changed the title Enable spanmetrics connector component. Enable the spanmetrics connector component. Feb 17, 2023
@djaglowski
Copy link
Member

Thanks for writing this up @kovrus. Sounds like a good plan, for both before and after enabling the connector.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants