[cmd/mdatagen] Add warnings in resource_attributes section #19174
Comments
dmitryax
changed the title
|
Pinging code owners for cmd/mdatagen: @dmitryax. See Adding Labels via Comments if you do not have permissions to add labels yourself. |
|
@dmitryax I would like to work on this issue. Can you please assign it to me? |
|
Thanks, @abhide . Assigned to you |
|
This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping Pinging code owners:
See Adding Labels via Comments if you do not have permissions to add labels yourself. |
|
This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping Pinging code owners:
See Adding Labels via Comments if you do not have permissions to add labels yourself. |
|
Started work on a PR #27257 @dmitryax would appreciate if you could take a look / give early feedback 🙇 I'm not sure what to do about this #27257 (comment) part did some manual tests of this PR and it seems to work |
**Description:** allow adding resource_attribute warnings **Link to tracking Issue:** #19174 **Testing:** - Generated unit tests - Tested manually with some changes to k8sclusterreceiver: ``` k8s.kubelet.version: description: The version of Kubelet running on the node. type: string enabled: false warnings: if_configured: This resource_attribute is deprecated and will be removed soon. opencensus.resourcetype: description: The OpenCensus resource type. type: string enabled: true warnings: if_enabled: This resource_attribute is deprecated and will be removed soon. ``` Gives the following output: ``` {"level":"warn","ts":1695985300.0413303,"caller":"metadata/generated_metrics.go:2201","msg":"[WARNING] `k8s.kubelet.version` should not be configured: This resource_attribute is deprecated and will be removed soon.","kind":"receiver","name":"k8s_cluster","data_type":"metrics"} {"level":"warn","ts":1695985300.041354,"caller":"metadata/generated_metrics.go:2207","msg":"[WARNING] `opencensus.resourcetype` should not be enabled: This resource_attribute is deprecated and will be removed soon.","kind":"receiver","name":"k8s_cluster","data_type":"metrics"} ```
…7257) **Description:** allow adding resource_attribute warnings **Link to tracking Issue:** open-telemetry#19174 **Testing:** - Generated unit tests - Tested manually with some changes to k8sclusterreceiver: ``` k8s.kubelet.version: description: The version of Kubelet running on the node. type: string enabled: false warnings: if_configured: This resource_attribute is deprecated and will be removed soon. opencensus.resourcetype: description: The OpenCensus resource type. type: string enabled: true warnings: if_enabled: This resource_attribute is deprecated and will be removed soon. ``` Gives the following output: ``` {"level":"warn","ts":1695985300.0413303,"caller":"metadata/generated_metrics.go:2201","msg":"[WARNING] `k8s.kubelet.version` should not be configured: This resource_attribute is deprecated and will be removed soon.","kind":"receiver","name":"k8s_cluster","data_type":"metrics"} {"level":"warn","ts":1695985300.041354,"caller":"metadata/generated_metrics.go:2207","msg":"[WARNING] `opencensus.resourcetype` should not be enabled: This resource_attribute is deprecated and will be removed soon.","kind":"receiver","name":"k8s_cluster","data_type":"metrics"} ```
|
This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping Pinging code owners:
See Adding Labels via Comments if you do not have permissions to add labels yourself. |
|
This issue has been closed as inactive because it has been stale for 120 days with no activity. |
Author of metadata.yaml should be able to specify the same warnings in
resource_attributessection as available in themetricssection. This is needed to provide a graceful way to handle changes to default/optional resource_attributes.The text was updated successfully, but these errors were encountered: