Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github.com/hashicorp/go-hclog upgrade causes problems #17009

Closed
codeboten opened this issue Dec 13, 2022 · 4 comments
Closed

github.com/hashicorp/go-hclog upgrade causes problems #17009

codeboten opened this issue Dec 13, 2022 · 4 comments

Comments

@codeboten
Copy link
Contributor

This upgrade causes the following errors:

# github.com/open-telemetry/opentelemetry-collector-contrib/exporter/logzioexporter
Error: ../../exporter/logzioexporter/exporter.go:68:13: cannot use &logger (value of type *hclog2ZapLogger) as type hclog.Logger in struct literal:
	*hclog2ZapLogger does not implement hclog.Logger (missing GetLevel method)
Error: ../../exporter/logzioexporter/logger.go:88:9: cannot use &hclog2ZapLogger{…} (value of type *hclog2ZapLogger) as type hclog.Logger in return statement:
	*hclog2ZapLogger does not implement hclog.Logger (missing GetLevel method)
Error: ../../exporter/logzioexporter/logger.go:93:9: cannot use &hclog2ZapLogger{…} (value of type *hclog2ZapLogger) as type hclog.Logger in return statement:
	*hclog2ZapLogger does not implement hclog.Logger (missing GetLevel method)
Error: ../../exporter/logzioexporter/logger.go:99:9: cannot use &hclog2ZapLogger{} (value of type *hclog2ZapLogger) as type hclog.Logger in return statement:
	*hclog2ZapLogger does not implement hclog.Logger (missing GetLevel method)
make: *** [Makefile:275: otelcontribcol] Error 2
Error: Process completed with exit code 2.

See https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/3687048650/jobs/6240112081#step:4:21549 for details

Originally posted by @codeboten in #16870 (review)

@github-actions
Copy link
Contributor

Pinging code owners for exporter/logzio: @jkowall @Doron-Bargo @yotamloe. See Adding Labels via Comments if you do not have permissions to add labels yourself.

@yotamloe
Copy link
Contributor

Hey, @codeboten thanks for reporting this issue. I opened a pr with the fix to the logger implementation. if all the tests for the pr will pass we can close this issue? anything else we should do?

codeboten pushed a commit that referenced this issue Dec 13, 2022
Description:
Added GetLevel method to logzio exporter logger
Link to tracking Issue:
#17009
@yotamloe
Copy link
Contributor

Hey @codeboten I saw that #17011 is merged, Can we close this issue now? 😁

@fatsheep9146
Copy link
Contributor

Hey @codeboten I saw that #17011 is merged, Can we close this issue now? 😁

Thanks for your contributions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants