[processor/spanmetrics] Does not recognize some dimensions

[edenkoveshi]

Description

I am using the Span Metrics processor to generate R.E.D metrics
I am using the dimensions feature to extract the following tags:

- http.method
- http.status_code
- http.target
- http.error_message
- otel.status_code
- otel.status_description
- error

All of those attributes exist in the span scope
All the http.* dimensions are extracted as expected, but the rest aren't
I am using the 2-pipline configuration described here

Collector version

0.60.0

Environment information

OpenTelemetry Collector Contrib 0.60.0 deployed on Openshift with OpenTelemetry operator 0.60.0

[github-actions]

Pinging code owners: @albertteoh. See Adding Labels via Comments if you do not have permissions to add labels yourself.

[evan-bradley]

Can you post the exact configuration you are using? I don't see any immediately obvious reason why the non-HTTP attributes would be excluded as dimensions.

[albertteoh]

Yup, I agree with @evan-bradley (and thanks for responding!).

As long as the non-HTTP attributes exist at the span or resource attributes at the time the span arrives in the spanmetrics processor, I also can't see why they wouldn't be included in the metrics. Relevant code here in case you were interested @edenkoveshi.

Perhaps they were somehow filtered out/dropped by another upstream processor?

[edenkoveshi]

Obviously there shouldn't be any difference between the HTTP and non-HTTP attributes, but it still happens..
This is the exact configuration:

receivers:
  jaeger:
  otlp:
    protocols:
      grpc:
      http:
  otlp/dummy:
    protocols:
      grpc:
        endpoint: "localhost:12345"

processors:
  batch:
  spanmetrics:
    metrics_exporter: prometheus
    dimensions:
    - http.method
    - http.status_code
    - http.target
    - http.error_message
    - otel.status_code
    - otel.status_description
    - error

exporters:
  jaeger:
    endpoint: <my-jaeger-endpoint>
 logging:
 prometheus:
   endpoint: "0.0.0.0:8889"

extensions:
  health_check:

service:
  extensions:
   - health_check
  pipelines:
    traces:
      receivers:
        - otlp
        -  jaeger
      processors:
       - spanmetrics
       - batch
      exporters:
       - logging
       - jaeger
    metrics:
       receivers: [otlp/dummy]
       exporters: [prometheus]
  telemetry:
     metrics:
        address: "0.0.0.0:8888"
     logs:
       level: "info"

Thank you for your help

[github-actions]

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

• processor/spanmetrics: @albertteoh

See Adding Labels via Comments if you do not have permissions to add labels yourself.

[albertteoh]

Hi @edenkoveshi, just revisiting some old tickets (sorry for the slow turnaround!) and noticed dimensions is misconfigured. It should resemble something like:

processors:
  spanmetrics:
    metrics_exporter: prometheus
    dimensions:
      - name: "otel.status_code"
        default: "bad otel status code"

I've tested this and confirmed it's working as expected.

[github-actions]

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

• processor/spanmetrics: @albertteoh

See Adding Labels via Comments if you do not have permissions to add labels yourself.

[crobert-1]

/label waiting-for-author