Skip to content

[receiver/couchdb]: Partial errors are not correctly recorded #13007

Closed
@BinaryFissionGames

Description

Describe the bug
Partial errors are not properly recorded if the payload returned by couchdb does not contain an expected metric.

This is because the scraper passes the ScrapeErrors struct into functions, instead of a pointer to the ScrapeErrors.
See:

var errors scrapererror.ScrapeErrors
c.recordCouchdbAverageRequestTimeDataPoint(now, stats, errors)
c.recordCouchdbHttpdBulkRequestsDataPoint(now, stats, errors)
c.recordCouchdbHttpdRequestsDataPoint(now, stats, errors)
c.recordCouchdbHttpdResponsesDataPoint(now, stats, errors)
c.recordCouchdbHttpdViewsDataPoint(now, stats, errors)
c.recordCouchdbDatabaseOpenDataPoint(now, stats, errors)
c.recordCouchdbFileDescriptorOpenDataPoint(now, stats, errors)
c.recordCouchdbDatabaseOperationsDataPoint(now, stats, errors)

Metadata

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions