-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Elastic Exporter: Elastic APM service graph "Time spent by span type" is empty #1277
Comments
cc @axw |
Indeed, this is a known limitation. The Elastic APM agents calculate the "Time spent by span type" metrics; it is impractical to calculate them once the spans have left the agent, as it depends on knowledge of the span hierarchy. To support this feature, I believe we would need to implement language-specific span processors for each OpenTelemetry SDK. |
We are considering building an aggregated metric calculator pipeline in the Otel collector which we would use to export metrics off spans. There are some challenges with the current SDK in running two pipelines (exporting traces and metrics) from a single trace input, but we are considering this. It will be discussed on the Jaeger community call today. |
That sounds like a useful feature! A span metrics pipeline might work but would have to aggregate complete traces (a la tail-based sampling), as the referenced metrics take into account time spent in nested spans. A more apt name for the metrics/graph might be "Time spent by span type, excluding any time spent in children of spans of that type." |
@cyrille-leclerc I don't see this coming any time soon. I'm inclined to close as WONTFIX and document the limitation for now, and consider implementing span processors for each of the SDKs to calculate and report the relevant metrics. WDYT? |
Thanks @axw . Closing for the moment as "won't fix" sounds good to me. |
Close as won't fix for the moment. |
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
Hi, is there any update on this? |
@kes2464 no, sorry. Please subscribe to elastic/apm#471 for updates. |
Describe the bug
Elastic APM service graph "Time spent by span type" is empty with a message "No data within this time range." when using the OpenTelemetry Java instrumentation. On the other side, when using the Elastic APM Java agent with the same application, the graph is properly filled.
Steps to reproduce
Instrument a java application connecting to a database and to a downstream service and look at the "Time spent by span type" graph.
Here is a sample with Spring Boot and PostgreSQL: https://github.com/cyrille-leclerc/my-shopping-cart/tree/otel-2020-10-15
What did you expect to see?
I expected to see the service graph "Time spent by span type" filled.
What did you see instead?
The graph "Time spent by span type" is empty with a message "No data within this time range."
What version did you use?
OpenTelemetry Collector Contrib Version: v0.12.0
OpenTelemetry Java Instrumentation Version: v0.8.0
What config did you use?
Environment
OS: MAcOS 10.15.7
Additional context
Add any other context about the problem here.
The text was updated successfully, but these errors were encountered: