[chore] more lint fixes (#31287)

Related #31240 Signed-off-by: Alex Boten <aboten@lightstep.com>
open-telemetry · Feb 15, 2024 · fee9489 · fee9489
1 parent 65948d4
commit fee9489
Show file tree

Hide file tree

Showing 17 changed files with 105 additions and 105 deletions.
diff --git a/receiver/opencensusreceiver/opencensus_test.go b/receiver/opencensusreceiver/opencensus_test.go
@@ -297,7 +297,7 @@ func TestReceiveOnUnixDomainSocket_endToEnd(t *testing.T) {
 `
 	c := http.Client{
 		Transport: &http.Transport{
-			DialContext: func(ctx context.Context, network, addr string) (conn net.Conn, err error) {
+			DialContext: func(context.Context, string, string) (conn net.Conn, err error) {
 				return net.Dial("unix", socketName)
 			},
 		},

diff --git a/receiver/oracledbreceiver/factory.go b/receiver/oracledbreceiver/factory.go
@@ -44,7 +44,7 @@ type sqlOpenerFunc func(dataSourceName string) (*sql.DB, error)
 
 func createReceiverFunc(sqlOpenerFunc sqlOpenerFunc, clientProviderFunc clientProviderFunc) receiver.CreateMetricsFunc {
 	return func(
-		ctx context.Context,
+		_ context.Context,
 		settings receiver.CreateSettings,
 		cfg component.Config,
 		consumer consumer.Metrics,

diff --git a/receiver/oracledbreceiver/scraper_test.go b/receiver/oracledbreceiver/scraper_test.go
@@ -49,7 +49,7 @@ func TestScraper_Scrape(t *testing.T) {
 	}{
 		{
 			name: "valid",
-			dbclientFn: func(db *sql.DB, s string, logger *zap.Logger) dbClient {
+			dbclientFn: func(_ *sql.DB, s string, _ *zap.Logger) dbClient {
 				return &fakeDbClient{
 					Responses: [][]metricRow{
 						queryResponses[s],
@@ -59,7 +59,7 @@ func TestScraper_Scrape(t *testing.T) {
 		},
 		{
 			name: "bad tablespace usage",
-			dbclientFn: func(db *sql.DB, s string, logger *zap.Logger) dbClient {
+			dbclientFn: func(_ *sql.DB, s string, _ *zap.Logger) dbClient {
 				if s == tablespaceUsageSQL {
 					return &fakeDbClient{Responses: [][]metricRow{
 						{
@@ -75,7 +75,7 @@ func TestScraper_Scrape(t *testing.T) {
 		},
 		{
 			name: "no limit on tablespace",
-			dbclientFn: func(db *sql.DB, s string, logger *zap.Logger) dbClient {
+			dbclientFn: func(_ *sql.DB, s string, _ *zap.Logger) dbClient {
 				if s == tablespaceMaxSpaceSQL {
 					return &fakeDbClient{Responses: [][]metricRow{
 						{
@@ -91,7 +91,7 @@ func TestScraper_Scrape(t *testing.T) {
 		},
 		{
 			name: "bad value on tablespace",
-			dbclientFn: func(db *sql.DB, s string, logger *zap.Logger) dbClient {
+			dbclientFn: func(_ *sql.DB, s string, _ *zap.Logger) dbClient {
 				if s == tablespaceMaxSpaceSQL {
 					return &fakeDbClient{Responses: [][]metricRow{
 						{

diff --git a/receiver/podmanreceiver/podman_connection.go b/receiver/podmanreceiver/podman_connection.go
@@ -62,7 +62,7 @@ func newPodmanConnection(logger *zap.Logger, endpoint string, sshKey string, ssh
 func tcpConnection(_url *url.URL) *http.Client {
 	return &http.Client{
 		Transport: &http.Transport{
-			DialContext: func(ctx context.Context, _, _ string) (net.Conn, error) {
+			DialContext: func(context.Context, string, string) (net.Conn, error) {
 				return net.Dial("tcp", _url.Host)
 			},
 			DisableCompression: true,
@@ -168,7 +168,7 @@ func sshConnection(logger *zap.Logger, _url *url.URL, secure bool, key, passphra
 
 	return &http.Client{
 		Transport: &http.Transport{
-			DialContext: func(ctx context.Context, _, _ string) (net.Conn, error) {
+			DialContext: func(context.Context, string, string) (net.Conn, error) {
 				return bastion.Dial("unix", _url.Path)
 			},
 		},

diff --git a/receiver/postgresqlreceiver/config_test.go b/receiver/postgresqlreceiver/config_test.go
@@ -27,7 +27,7 @@ func TestValidate(t *testing.T) {
 	}{
 		{
 			desc:                  "missing username and password",
-			defaultConfigModifier: func(cfg *Config) {},
+			defaultConfigModifier: func(*Config) {},
 			expected: multierr.Combine(
 				errors.New(ErrNoUsername),
 				errors.New(ErrNoPassword),

diff --git a/receiver/prometheusreceiver/internal/staleness_end_to_end_test.go b/receiver/prometheusreceiver/internal/staleness_end_to_end_test.go
@@ -50,7 +50,7 @@ func TestStalenessMarkersEndToEnd(t *testing.T) {
 
 	// 1. Setup the server that sends series that intermittently appear and disappear.
 	n := &atomic.Uint64{}
-	scrapeServer := httptest.NewServer(http.HandlerFunc(func(rw http.ResponseWriter, req *http.Request) {
+	scrapeServer := httptest.NewServer(http.HandlerFunc(func(rw http.ResponseWriter, _ *http.Request) {
 		// Increment the scrape count atomically per scrape.
 		i := n.Add(1)
 
@@ -81,7 +81,7 @@ jvm_memory_pool_bytes_used{pool="CodeHeap 'non-nmethods'"} %.1f`, float64(i))
 
 	// 2. Set up the Prometheus RemoteWrite endpoint.
 	prweUploads := make(chan *prompb.WriteRequest)
-	prweServer := httptest.NewServer(http.HandlerFunc(func(rw http.ResponseWriter, req *http.Request) {
+	prweServer := httptest.NewServer(http.HandlerFunc(func(_ http.ResponseWriter, req *http.Request) {
 		// Snappy decode the uploads.
 		payload, rerr := io.ReadAll(req.Body)
 		require.NoError(t, rerr)

diff --git a/receiver/prometheusreceiver/metrics_receiver_test.go b/receiver/prometheusreceiver/metrics_receiver_test.go
@@ -1606,7 +1606,7 @@ func TestGCInterval(t *testing.T) {
 
 func TestUserAgent(t *testing.T) {
 	uaCh := make(chan string, 1)
-	svr := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
+	svr := httptest.NewServer(http.HandlerFunc(func(_ http.ResponseWriter, r *http.Request) {
 		select {
 		case uaCh <- r.UserAgent():
 		default:

diff --git a/receiver/rabbitmqreceiver/client_test.go b/receiver/rabbitmqreceiver/client_test.go
@@ -99,7 +99,7 @@ func TestGetQueuesDetails(t *testing.T) {
 			desc: "Non-200 Response",
 			testFunc: func(t *testing.T) {
 				// Setup test server
-				ts := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
+				ts := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, _ *http.Request) {
 					w.WriteHeader(http.StatusUnauthorized)
 				}))
 				defer ts.Close()
@@ -115,7 +115,7 @@ func TestGetQueuesDetails(t *testing.T) {
 			desc: "Bad payload returned",
 			testFunc: func(t *testing.T) {
 				// Setup test server
-				ts := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
+				ts := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, _ *http.Request) {
 					_, err := w.Write([]byte("{}"))
 					require.NoError(t, err)
 				}))
@@ -134,7 +134,7 @@ func TestGetQueuesDetails(t *testing.T) {
 				data := loadAPIResponseData(t, queuesAPIResponseFile)
 
 				// Setup test server
-				ts := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
+				ts := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, _ *http.Request) {
 					_, err := w.Write(data)
 					require.NoError(t, err)
 				}))

diff --git a/receiver/rabbitmqreceiver/scraper_test.go b/receiver/rabbitmqreceiver/scraper_test.go
@@ -84,22 +84,22 @@ func TestScaperScrape(t *testing.T) {
 	}{
 		{
 			desc: "Nil client",
-			setupMockClient: func(t *testing.T) client {
+			setupMockClient: func(*testing.T) client {
 				return nil
 			},
-			expectedMetricGen: func(t *testing.T) pmetric.Metrics {
+			expectedMetricGen: func(*testing.T) pmetric.Metrics {
 				return pmetric.NewMetrics()
 			},
 			expectedErr: errClientNotInit,
 		},
 		{
 			desc: "API Call Failure",
-			setupMockClient: func(t *testing.T) client {
+			setupMockClient: func(*testing.T) client {
 				mockClient := mocks.MockClient{}
 				mockClient.On("GetQueues", mock.Anything).Return(nil, errors.New("some api error"))
 				return &mockClient
 			},
-			expectedMetricGen: func(t *testing.T) pmetric.Metrics {
+			expectedMetricGen: func(*testing.T) pmetric.Metrics {
 
 				return pmetric.NewMetrics()
 			},

diff --git a/receiver/riakreceiver/client_test.go b/receiver/riakreceiver/client_test.go
@@ -83,7 +83,7 @@ func TestNewClient(t *testing.T) {
 func TestGetStatsDetails(t *testing.T) {
 	t.Run("Non-200 Response", func(t *testing.T) {
 		// Setup test server
-		ts := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
+		ts := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, _ *http.Request) {
 			w.WriteHeader(http.StatusUnauthorized)
 		}))
 		defer ts.Close()
@@ -99,7 +99,7 @@ func TestGetStatsDetails(t *testing.T) {
 		data := loadAPIResponseData(t, statsAPIResponseFile)
 
 		// Setup test server
-		ts := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
+		ts := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, _ *http.Request) {
 			_, err := w.Write(data)
 			require.NoError(t, err)
 		}))

diff --git a/receiver/riakreceiver/scraper_test.go b/receiver/riakreceiver/scraper_test.go
@@ -87,10 +87,10 @@ func TestScaperScrape(t *testing.T) {
 	}{
 		{
 			desc: "Nil client",
-			setupMockClient: func(t *testing.T) client {
+			setupMockClient: func(*testing.T) client {
 				return nil
 			},
-			expectedMetricGen: func(t *testing.T) pmetric.Metrics {
+			expectedMetricGen: func(*testing.T) pmetric.Metrics {
 				return pmetric.NewMetrics()
 			},
 			setupCfg: func() *Config {
@@ -100,12 +100,12 @@ func TestScaperScrape(t *testing.T) {
 		},
 		{
 			desc: "API Call Failure",
-			setupMockClient: func(t *testing.T) client {
+			setupMockClient: func(*testing.T) client {
 				mockClient := mocks.MockClient{}
 				mockClient.On("GetStats", mock.Anything).Return(nil, errors.New("some api error"))
 				return &mockClient
 			},
-			expectedMetricGen: func(t *testing.T) pmetric.Metrics {
+			expectedMetricGen: func(*testing.T) pmetric.Metrics {
 				return pmetric.NewMetrics()
 			},
 			setupCfg: func() *Config {

diff --git a/receiver/saphanareceiver/client_test.go b/receiver/saphanareceiver/client_test.go
@@ -136,16 +136,16 @@ func TestSimpleQueryOutput(t *testing.T) {
 		orderedStats: []queryStat{
 			{
 				key: "value",
-				addMetricFunction: func(mb *metadata.MetricsBuilder, t pcommon.Timestamp, val string,
-					m map[string]string) error {
+				addMetricFunction: func(*metadata.MetricsBuilder, pcommon.Timestamp, string,
+					map[string]string) error {
 					// Function is a no-op as it's not required for this test
 					return nil
 				},
 			},
 			{
 				key: "rate",
-				addMetricFunction: func(mb *metadata.MetricsBuilder, t pcommon.Timestamp, val string,
-					m map[string]string) error {
+				addMetricFunction: func(*metadata.MetricsBuilder, pcommon.Timestamp, string,
+					map[string]string) error {
 					// Function is a no-op as it's not required for this test
 					return nil
 				},
@@ -192,16 +192,16 @@ func TestNullOutput(t *testing.T) {
 		orderedStats: []queryStat{
 			{
 				key: "value",
-				addMetricFunction: func(mb *metadata.MetricsBuilder, t pcommon.Timestamp, val string,
-					m map[string]string) error {
+				addMetricFunction: func(*metadata.MetricsBuilder, pcommon.Timestamp, string,
+					map[string]string) error {
 					// Function is a no-op as it's not required for this test
 					return nil
 				},
 			},
 			{
 				key: "rate",
-				addMetricFunction: func(mb *metadata.MetricsBuilder, t pcommon.Timestamp, val string,
-					m map[string]string) error {
+				addMetricFunction: func(*metadata.MetricsBuilder, pcommon.Timestamp, string,
+					map[string]string) error {
 					// Function is a no-op as it's not required for this test
 					return nil
 				},

diff --git a/receiver/saphanareceiver/config_test.go b/receiver/saphanareceiver/config_test.go
@@ -27,7 +27,7 @@ func TestValidate(t *testing.T) {
 	}{
 		{
 			desc:                  "missing username and password",
-			defaultConfigModifier: func(cfg *Config) {},
+			defaultConfigModifier: func(*Config) {},
 			expected: multierr.Combine(
 				errors.New(ErrNoUsername),
 				errors.New(ErrNoPassword),