Check that false is returned with error

open-telemetry · Jun 9, 2023 · e3b0ab2 · e3b0ab2
1 parent 387625c
commit e3b0ab2
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/pkg/ottl/ottlfuncs/func_is_map_test.go b/pkg/ottl/ottlfuncs/func_is_map_test.go
@@ -65,7 +65,8 @@ func Test_IsMap_Error(t *testing.T) {
 			return nil, ottl.TypeError("")
 		},
 	})
-	_, err := exprFunc(context.Background(), nil)
+	result, err := exprFunc(context.Background(), nil)
+	assert.Equal(t, false, result)
 	assert.Error(t, err)
 	_, ok := err.(ottl.TypeError)
 	assert.False(t, ok)

diff --git a/pkg/ottl/ottlfuncs/func_is_string_test.go b/pkg/ottl/ottlfuncs/func_is_string_test.go
@@ -65,7 +65,8 @@ func Test_IsString_Error(t *testing.T) {
 			return nil, ottl.TypeError("")
 		},
 	})
-	_, err := exprFunc(context.Background(), nil)
+	result, err := exprFunc(context.Background(), nil)
+	assert.Equal(t, false, result)
 	assert.Error(t, err)
 	_, ok := err.(ottl.TypeError)
 	assert.False(t, ok)