Skip to content

Commit

Permalink
rebase + review feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
moh-osman3 committed Sep 12, 2024
1 parent 57f9d56 commit c04c5bd
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 7 deletions.
2 changes: 1 addition & 1 deletion receiver/otelarrowreceiver/factory.go
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ const (
defaultGRPCEndpoint = "0.0.0.0:4317"

defaultMemoryLimitMiB = 128
defaultRequestLimitMiB = defaultMemoryLimitMiB / 2
defaultRequestLimitMiB = 128
defaultWaiterLimit = 1000
)

Expand Down
3 changes: 1 addition & 2 deletions receiver/otelarrowreceiver/internal/logs/otlp.go
Original file line number Diff line number Diff line change
Expand Up @@ -54,8 +54,7 @@ func (r *Receiver) Export(ctx context.Context, req plogotlp.ExportRequest) (plog
return plogotlp.NewExportResponse(), err
}
defer func() {
releaseErr := r.boundedQueue.Release(sizeBytes)
if releaseErr != nil {
if releaseErr := r.boundedQueue.Release(sizeBytes); releaseErr != nil {
r.logger.Error("Error releasing bytes from semaphore", zap.Error(releaseErr))
}
}()
Expand Down
3 changes: 1 addition & 2 deletions receiver/otelarrowreceiver/internal/metrics/otlp.go
Original file line number Diff line number Diff line change
Expand Up @@ -54,8 +54,7 @@ func (r *Receiver) Export(ctx context.Context, req pmetricotlp.ExportRequest) (p
return pmetricotlp.NewExportResponse(), err
}
defer func() {
releaseErr := r.boundedQueue.Release(sizeBytes)
if releaseErr != nil {
if releaseErr := r.boundedQueue.Release(sizeBytes); releaseErr != nil {
r.logger.Error("Error releasing bytes from semaphore", zap.Error(releaseErr))
}
}()
Expand Down
3 changes: 1 addition & 2 deletions receiver/otelarrowreceiver/internal/trace/otlp.go
Original file line number Diff line number Diff line change
Expand Up @@ -54,8 +54,7 @@ func (r *Receiver) Export(ctx context.Context, req ptraceotlp.ExportRequest) (pt
return ptraceotlp.NewExportResponse(), err
}
defer func() {
releaseErr := r.boundedQueue.Release(sizeBytes)
if releaseErr != nil {
if releaseErr := r.boundedQueue.Release(sizeBytes); releaseErr != nil {
r.logger.Error("Error releasing bytes from semaphore", zap.Error(releaseErr))
}
}()
Expand Down

0 comments on commit c04c5bd

Please sign in to comment.