Skip to content

Commit

Permalink
Add to removedSettings
Browse files Browse the repository at this point in the history
  • Loading branch information
songy23 committed Jul 22, 2024
1 parent dba8f51 commit 9edd312
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 0 deletions.
5 changes: 5 additions & 0 deletions exporter/datadogexporter/config.go
Original file line number Diff line number Diff line change
Expand Up @@ -574,6 +574,11 @@ var removedSettings = []renameError{
newName: "metrics::instrumentation_scope_as_tags",
issueNumber: 11135,
},
{
oldName: "traces::peer_service_aggregation",
newName: "traces::peer_tags_aggregation",
issueNumber: 34177,
},
}

// Error implements the error interface.
Expand Down
9 changes: 9 additions & 0 deletions exporter/datadogexporter/config_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -280,6 +280,15 @@ func TestUnmarshal(t *testing.T) {
}),
err: "\"metrics::instrumentation_library_metadata_as_tags\" was removed in favor of \"metrics::instrumentation_scope_as_tags\". See https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/11135",
},
{
name: "peer_service_aggregation custom error",
configMap: confmap.NewFromStringMap(map[string]any{
"traces": map[string]any{
"peer_service_aggregation": true,
},
}),
err: "\"traces::peer_service_aggregation\" was removed in favor of \"traces::peer_tags_aggregation\". See https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/34177",
},
{
name: "Empty metric endpoint",
configMap: confmap.NewFromStringMap(map[string]any{
Expand Down

0 comments on commit 9edd312

Please sign in to comment.