Skip to content

Commit

Permalink
Add GMP changelog, mark gmp mutating, update go.mod
Browse files Browse the repository at this point in the history
  • Loading branch information
damemi committed Sep 24, 2024
1 parent 365ff2d commit 214cc0c
Show file tree
Hide file tree
Showing 3 changed files with 32 additions and 2 deletions.
2 changes: 1 addition & 1 deletion .chloggen/gcp-0482.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ change_type: enhancement
component: googlecloudexporter

# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`).
note: Google Cloud and GMP exporters are marked as mutating.
note: Google Cloud exporter is marked as mutating.

# Mandatory: One or more tracking issues related to the change. You can use the PR number here if no issue exists.
issues: [35366]
Expand Down
27 changes: 27 additions & 0 deletions .chloggen/gmp-0482.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
# Use this changelog template to create an entry for release notes.

# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix'
change_type: enhancement

# The name of the component, or a single word describing the area of concern, (e.g. filelogreceiver)
component: googlemanagedprometheusexporter

# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`).
note: GMP exporter is marked as mutating.

# Mandatory: One or more tracking issues related to the change. You can use the PR number here if no issue exists.
issues: [35366]

# (Optional) One or more lines of additional information to render under the primary note.
# These lines will be padded with 2 spaces and then inserted directly into the document.
# Use pipe (|) for multiline entries.
subtext:

# If your change doesn't affect end users or the exported elements of any package,
# you should instead start your pull request title with [chore] or use the "Skip Changelog" label.
# Optional: The change log or logs in which this entry should be included.
# e.g. '[user]' or '[user, api]'
# Include 'user' if the change is relevant to end users.
# Include 'api' if there is a change to a library API.
# Default: '[user]'
change_logs: []
5 changes: 4 additions & 1 deletion exporter/googlemanagedprometheusexporter/factory.go
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ import (
"github.com/GoogleCloudPlatform/opentelemetry-operations-go/exporter/collector"
"github.com/GoogleCloudPlatform/opentelemetry-operations-go/exporter/collector/googlemanagedprometheus"
"go.opentelemetry.io/collector/component"
"go.opentelemetry.io/collector/consumer"
"go.opentelemetry.io/collector/exporter"
"go.opentelemetry.io/collector/exporter/exporterhelper"

Expand Down Expand Up @@ -64,5 +65,7 @@ func createMetricsExporter(
// Disable exporterhelper Timeout, since we are using a custom mechanism
// within exporter itself
exporterhelper.WithTimeout(exporterhelper.TimeoutConfig{Timeout: 0}),
exporterhelper.WithQueue(eCfg.QueueSettings))
exporterhelper.WithQueue(eCfg.QueueSettings),
exporterhelper.WithCapabilities(consumer.Capabilities{MutatesData: true}),
)
}

0 comments on commit 214cc0c

Please sign in to comment.