fir err msg

Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
open-telemetry · Oct 3, 2024 · 062d966 · 062d966
1 parent 79bffb5
commit 062d966
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 13 deletions.
diff --git a/internal/metadataproviders/kubeadm/metadata.go b/internal/metadataproviders/kubeadm/metadata.go
@@ -25,9 +25,6 @@ type kubeadmProvider struct {
 }
 
 func NewProvider(configMapName string, configMapNamespace string, apiConf k8sconfig.APIConfig) (Provider, error) {
-	if configMapName == "" || configMapNamespace == "" {
-		return nil, fmt.Errorf("configMapName and configMapNamespace can't be empty")
-	}
 	k8sAPIClient, err := k8sconfig.MakeClient(apiConf)
 	if err != nil {
 		return nil, fmt.Errorf("failed to create K8s API client: %w", err)

diff --git a/internal/metadataproviders/kubeadm/metadata_test.go b/internal/metadataproviders/kubeadm/metadata_test.go
@@ -20,16 +20,7 @@ func TestNewProvider(t *testing.T) {
 	t.Setenv("KUBERNETES_SERVICE_HOST", "127.0.0.1")
 	t.Setenv("KUBERNETES_SERVICE_PORT", "6443")
 
-	_, err := NewProvider("", "", k8sconfig.APIConfig{AuthType: k8sconfig.AuthTypeNone})
-	assert.EqualError(t, err, "configMapName and configMapNamespace can't be empty")
-
-	_, err = NewProvider("", "ns", k8sconfig.APIConfig{AuthType: k8sconfig.AuthTypeNone})
-	assert.EqualError(t, err, "configMapName and configMapNamespace can't be empty")
-
-	_, err = NewProvider("name", "", k8sconfig.APIConfig{AuthType: k8sconfig.AuthTypeNone})
-	assert.EqualError(t, err, "configMapName and configMapNamespace can't be empty")
-
-	_, err = NewProvider("name", "ns", k8sconfig.APIConfig{AuthType: k8sconfig.AuthTypeNone})
+	_, err := NewProvider("name", "ns", k8sconfig.APIConfig{AuthType: k8sconfig.AuthTypeNone})
 	assert.NoError(t, err)
 }