Add .proto files and generate Go Protobufs #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tigrannajaryan
force-pushed
the
add-protobufs
branch
from
5b8d484 to
247a44c
Compare
djaglowski
approved these changes
Nov 9, 2021
codeboten
reviewed
Nov 9, 2021
tigrannajaryan
force-pushed
the
add-protobufs
branch
from
247a44c to
d1d9771
Compare
This adds .proto file that matches the current spec at https://github.com/open-telemetry/opamp-spec I also added a makefile with gen-proto target to generate the go Protobufs. I suggest that we keep the .proto and generated files in this repo for now to keep initial development fast. Kept in "internal" for now to avoid leaking unwanted dependency. We can move the .proto to a separate repository later if we decide that's the right approach (similar to OTLP proto files).
tigrannajaryan
force-pushed
the
add-protobufs
branch
from
d1d9771 to
8e05544
Compare
Aneurysm9
reviewed
Nov 9, 2021
|
@codeboten @Aneurysm9 ok to merge? |
jmacd
approved these changes
Nov 10, 2021
|
OK, merging, all comments resolved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds .proto file that matches the current spec at
https://github.com/open-telemetry/opamp-spec
I also added a makefile with gen-proto target to generate
the go Protobufs.
I suggest that we keep the .proto and generated files in
this repo for now to keep initial development fast. Kept in
"internal" for now to avoid leaking unwanted dependency.
We can move the .proto to a separate repository later if we
decide that's the right approach (similar to OTLP proto files).