Fix race condition on TestConnectionAllowsConcurrentWrites #282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Paschalis Tsilias <paschalis.tsilias@grafana.com>
|
@evan-bradley can you review as the author of the test? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #282 +/- ##
=======================================
Coverage 75.96% 75.96%
=======================================
Files 25 25
Lines 1656 1656
=======================================
Hits 1258 1258
Misses 291 291
Partials 107 107 ☔ View full report in Codecov by Sentry. |
evan-bradley
approved these changes
Jun 7, 2024
|
Thank you @tpaschalis! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a race condition on TestConnectionAllowsConcurrentWrites.
Before this change, the select case here was a no-op and would always fall through to the default case; using a channel allows proper synchronization.
To validate the before/after behavior, one can use the following command from the repo root.
Fixes #280