Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update otel bot permissions #2239

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

svrnm
Copy link
Member

@svrnm svrnm commented Jul 25, 2024

Related to #2234

Updated: This is required for #2277, needed by @open-telemetry/javascript-maintainers: "read:org permission would allow us to update descriptions for PRs opened by @opentelemetrybot. Recently we added a workflow to automatically create release PRs, but the workflow can't edit the description of its own PR without read:org."

@jack-berg
Copy link
Member

FYI, I've already assigned this scope to the OpenTelemetry bot. If we end up not accepting this PR, we should revert the scope.

@jack-berg
Copy link
Member

FYI, I've reverted the read:org permission from the opentelemetrybot org secret token, since it seems like we're likely to go in a different direction than this.

@pichlermarc
Copy link
Member

FYI, I've reverted the read:org permission from the opentelemetrybot org secret token, since it seems like we're likely to go in a different direction than this.

We (OTel JS SIG) would actually appreciate having the read:org permission. 🙂

It would allow us to update descriptions for PRs opened by @opentelemetrybot. Recently we added a workflow to automatically create release PRs, the workflow can't edit the description of its own PR without read:org permissions.

See open-telemetry/opentelemetry-js#4849, https://github.com/open-telemetry/opentelemetry-js/actions/runs/10195580438/job/28204768571#step:8:389

@trask
Copy link
Member

trask commented Aug 12, 2024

We (OTel JS SIG) would actually appreciate having the read:org permission.

I think it's ok to give @opentelemetrybot the read:org permission

from https://docs.github.com/en/apps/oauth-apps/building-oauth-apps/scopes-for-oauth-apps#available-scopes, read:org is:

Read-only access to organization membership, organization projects, and team membership.

and @opentelemetrybot doesn't have any special read privileges to the @open-telemetry org (it is just a normal org member).

@pichlermarc can you open a repository maintenance issue in this repo and we can see if there's agreement from others?

@pichlermarc
Copy link
Member

@pichlermarc can you open a repository maintenance issue in this repo and we can see if there's agreement from others?

Sure thing - opened #2277 just now. Thanks 🙌

@trask
Copy link
Member

trask commented Aug 14, 2024

FYI, I've reverted the read:org permission from the opentelemetrybot org secret token, since it seems like we're likely to go in a different direction than this.

@jack-berg can you re-revert it now that we need it for #2277? (and then also we can re-test without triage permission in the website repo)

@jack-berg
Copy link
Member

@jack-berg can you re-revert it now that we need it for #2277? (and then also we can re-test without triage permission in the website repo)

done

@trask
Copy link
Member

trask commented Aug 15, 2024

@open-telemetry/technical-committee @open-telemetry/governance-committee please review this PR, we want to move forward with it again, thanks

@tigrannajaryan
Copy link
Member

@open-telemetry/technical-committee @open-telemetry/governance-committee please review this PR, we want to move forward with it again, thanks

I am confused about what is being added after reverts and re-reverts :-)

@svrnm can you please update the PR description to clarify the change, why and what is being changed?

@svrnm
Copy link
Member Author

svrnm commented Sep 4, 2024

I am confused about what is being added after reverts and re-reverts :-)
@svrnm can you please update the PR description to clarify the change, why and what is being changed?

I am confused as well, but if I understand it correctly the JS SIG wants to have the permissions I listed here, so the PR content should be good? Trying to update the description to reflect that

Copy link
Member

@pichlermarc pichlermarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am confused as well, but if I understand it correctly the JS SIG wants to have the permissions I listed here, so the PR content should be good?

Yes that is correct - the content of this PR now accurately reflects what the current permissions are (and they align with what the JS SIG needs). 🙂

@trask
Copy link
Member

trask commented Sep 4, 2024

@open-telemetry/technical-committee @open-telemetry/governance-committee the PR description is updated and ready for review, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants