Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Metrics table generation from yaml #79

Merged
merged 59 commits into from
Jan 20, 2023
Merged

Metrics table generation from yaml #79

merged 59 commits into from
Jan 20, 2023

Commits on Jan 25, 2022

  1. functionality for metrics table generation from yaml

    @jamesmoessis
    jamesmoessis committed Jan 25, 2022
    Configuration menu
    Copy the full SHA
    c1ccabd View commit details
    Browse the repository at this point in the history

  2. tests for metric convention yaml->markdown

    @jamesmoessis
    jamesmoessis committed Jan 25, 2022
    Configuration menu
    Copy the full SHA
    40d73ef View commit details
    Browse the repository at this point in the history

  3. appease linter

    @jamesmoessis
    jamesmoessis committed Jan 25, 2022
    Configuration menu
    Copy the full SHA
    beead27 View commit details
    Browse the repository at this point in the history

  4. use zip instead of enumerate

    @jamesmoessis
    jamesmoessis committed Jan 25, 2022
    Configuration menu
    Copy the full SHA
    6e4ff11 View commit details
    Browse the repository at this point in the history

  5. raise error if metric_table is specified on non-metric semconv

    @jamesmoessis
    jamesmoessis committed Jan 25, 2022
    Configuration menu
    Copy the full SHA
    cd9d815 View commit details
    Browse the repository at this point in the history

  6. update syntax.md with initial metrics syntax

    @jamesmoessis
    jamesmoessis committed Jan 25, 2022
    Configuration menu
    Copy the full SHA
    f4aef51 View commit details
    Browse the repository at this point in the history

  7. remove duplicated code and files

    @jamesmoessis
    jamesmoessis committed Jan 25, 2022
    Configuration menu
    Copy the full SHA
    2421f0b View commit details
    Browse the repository at this point in the history

  8. add extra_yaml_files param and use it in metric_table test

    @jamesmoessis
    jamesmoessis committed Jan 25, 2022
    Configuration menu
    Copy the full SHA
    5ac5895 View commit details
    Browse the repository at this point in the history

Commits on Jan 27, 2022

  1. use 'FQN = prefix + id' for metric FQNs

    @jamesmoessis
    jamesmoessis committed Jan 27, 2022
    Configuration menu
    Copy the full SHA
    bec1a1b View commit details
    Browse the repository at this point in the history

Commits on Apr 14, 2022

  1. change InstrumentKind enum to ALL_CAPS and remove sync/async distinction

    @jamesmoessis
    jamesmoessis committed Apr 14, 2022
    Configuration menu
    Copy the full SHA
    22373cd View commit details
    Browse the repository at this point in the history

  2. implement syntax review and semantics docs

    @jamesmoessis
    jamesmoessis committed Apr 14, 2022
    Configuration menu
    Copy the full SHA
    ec98643 View commit details
    Browse the repository at this point in the history

  3. raise error from different position to avoid re-raising

    @jamesmoessis
    jamesmoessis committed Apr 14, 2022
    Configuration menu
    Copy the full SHA
    9bcc6e4 View commit details
    Browse the repository at this point in the history

  4. remove markdown link

    @jamesmoessis
    jamesmoessis committed Apr 14, 2022
    Configuration menu
    Copy the full SHA
    87dfe5d View commit details
    Browse the repository at this point in the history

  5. implement various review items

    @jamesmoessis
    jamesmoessis committed Apr 14, 2022
    Configuration menu
    Copy the full SHA
    6df71da View commit details
    Browse the repository at this point in the history

  6. Merge branch 'main' into metrics-semconv

    @jamesmoessis
    jamesmoessis committed Apr 14, 2022
    Configuration menu
    Copy the full SHA
    a96e962 View commit details
    Browse the repository at this point in the history

  7. upgrade black version to try solve build failure

    @jamesmoessis
    jamesmoessis committed Apr 14, 2022
    Configuration menu
    Copy the full SHA
    93eb443 View commit details
    Browse the repository at this point in the history

  8. appease linter

    @jamesmoessis
    jamesmoessis committed Apr 14, 2022
    Configuration menu
    Copy the full SHA
    a77142c View commit details
    Browse the repository at this point in the history

  9. fix typo

    @jamesmoessis
    jamesmoessis committed Apr 14, 2022
    Configuration menu
    Copy the full SHA
    c50b9e0 View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2022

  1. stop using enum for instrument kind

    @jamesmoessis
    jamesmoessis committed Apr 26, 2022
    Configuration menu
    Copy the full SHA
    13316cd View commit details
    Browse the repository at this point in the history

  2. extract attribute table writing to own function

    @jamesmoessis
    jamesmoessis committed Apr 26, 2022
    Configuration menu
    Copy the full SHA
    e01f296 View commit details
    Browse the repository at this point in the history

  3. appease linter

    @jamesmoessis
    jamesmoessis committed Apr 26, 2022
    Configuration menu
    Copy the full SHA
    5fbdcf9 View commit details
    Browse the repository at this point in the history

  4. add link to UCUM

    @jamesmoessis
    jamesmoessis committed Apr 26, 2022
    Configuration menu
    Copy the full SHA
    a3b7e7f View commit details
    Browse the repository at this point in the history

  5. consistent camelcase syntax

    @jamesmoessis
    jamesmoessis committed Apr 26, 2022
    Configuration menu
    Copy the full SHA
    8ec68ed View commit details
    Browse the repository at this point in the history

Commits on Jun 6, 2022

  1. Merge branch 'main' into metrics-semconv

    @jamesmoessis
    jamesmoessis committed Jun 6, 2022
    Configuration menu
    Copy the full SHA
    e6d4da2 View commit details
    Browse the repository at this point in the history

  2. Address reyang comments

    @jamesmoessis
    jamesmoessis committed Jun 6, 2022
    Configuration menu
    Copy the full SHA
    dfe7b0e View commit details
    Browse the repository at this point in the history

  3. update tests so they pass with latest main

    @jamesmoessis
    jamesmoessis committed Jun 6, 2022
    Configuration menu
    Copy the full SHA
    cde4200 View commit details
    Browse the repository at this point in the history

  4. move logic of stripping metric. prefix

    @jamesmoessis
    jamesmoessis committed Jun 6, 2022
    Configuration menu
    Copy the full SHA
    9217e78 View commit details
    Browse the repository at this point in the history

  5. appease linter

    @jamesmoessis
    jamesmoessis committed Jun 6, 2022
    Configuration menu
    Copy the full SHA
    9178ab3 View commit details
    Browse the repository at this point in the history

  6. remove 'metric.' prefix so we don't have to removeprefix() when seria… 

    …lising
    @jamesmoessis
    jamesmoessis committed Jun 6, 2022
    Configuration menu
    Copy the full SHA
    a012741 View commit details
    Browse the repository at this point in the history

Commits on Sep 8, 2022

  1. Merge branch 'main' into metrics-semconv

    @jamesmoessis
    jamesmoessis committed Sep 8, 2022
    Configuration menu
    Copy the full SHA
    b06e586 View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2022

  1. make test match current changed expectation for requirement level

    @jamesmoessis
    jamesmoessis committed Sep 9, 2022
    Configuration menu
    Copy the full SHA
    f028520 View commit details
    Browse the repository at this point in the history

  2. new yaml structure for metrics

    @jamesmoessis
    jamesmoessis committed Sep 9, 2022
    Configuration menu
    Copy the full SHA
    68b1154 View commit details
    Browse the repository at this point in the history

  3. change the structure of yaml for metrics

    @jamesmoessis
    jamesmoessis committed Sep 9, 2022
    Configuration menu
    Copy the full SHA
    849c376 View commit details
    Browse the repository at this point in the history

  4. foo bar test for new metric structure

    @jamesmoessis
    jamesmoessis committed Sep 9, 2022
    Configuration menu
    Copy the full SHA
    fd33c98 View commit details
    Browse the repository at this point in the history

  5. alter syntax definition in readme

    @jamesmoessis
    jamesmoessis committed Sep 9, 2022
    Configuration menu
    Copy the full SHA
    6536fb8 View commit details
    Browse the repository at this point in the history

  6. simplify test slightly

    @jamesmoessis
    jamesmoessis committed Sep 9, 2022
    Configuration menu
    Copy the full SHA
    9e7e718 View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2022

  1. implement several review items

    @jamesmoessis
    jamesmoessis committed Sep 13, 2022
    Configuration menu
    Copy the full SHA
    f6f1d5a View commit details
    Browse the repository at this point in the history

  2. units -> unit in some places I missed before

    @jamesmoessis
    jamesmoessis committed Sep 13, 2022
    Configuration menu
    Copy the full SHA
    3f3a104 View commit details
    Browse the repository at this point in the history

  3. newline for readability

    @jamesmoessis
    jamesmoessis committed Sep 13, 2022
    Configuration menu
    Copy the full SHA
    f2f64b6 View commit details
    Browse the repository at this point in the history

  4. remove unneeded yaml definition

    @jamesmoessis
    jamesmoessis committed Sep 13, 2022
    Configuration menu
    Copy the full SHA
    766cc5d View commit details
    Browse the repository at this point in the history

  5. add JSON schema definition for MetricSemanticConvention

    @jamesmoessis
    jamesmoessis committed Sep 13, 2022
    Configuration menu
    Copy the full SHA
    f1f7e73 View commit details
    Browse the repository at this point in the history

  6. add changelog

    @jamesmoessis
    jamesmoessis committed Sep 13, 2022
    Configuration menu
    Copy the full SHA
    167ba00 View commit details
    Browse the repository at this point in the history

  7. appease linter

    @jamesmoessis
    jamesmoessis committed Sep 13, 2022
    Configuration menu
    Copy the full SHA
    5c38093 View commit details
    Browse the repository at this point in the history

Commits on Sep 16, 2022

  1. address comment regarding instrument types

    @jamesmoessis
    jamesmoessis committed Sep 16, 2022
    Configuration menu
    Copy the full SHA
    8fb5af0 View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2022

  1. update docs on metric_table semconv generator example

    @jamesmoessis
    jamesmoessis committed Oct 5, 2022
    Configuration menu
    Copy the full SHA
    3a775d3 View commit details
    Browse the repository at this point in the history

Commits on Oct 19, 2022

  1. restore event name in syntax.md which erroneously removed

    @jamesmoessis
    jamesmoessis committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    d237bf2 View commit details
    Browse the repository at this point in the history

  2. add more metrics/attributes to test, clarifying intentions

    @jamesmoessis
    jamesmoessis committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    e8259dd View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2022

  1. use different prefix in tests for clarity

    @jamesmoessis
    jamesmoessis committed Oct 24, 2022
    Configuration menu
    Copy the full SHA
    6a67c74 View commit details
    Browse the repository at this point in the history

  2. differentiate parent and concrete metric types with different semanti… 

    …c convention types metric and metric_group
    @jamesmoessis
    jamesmoessis committed Oct 24, 2022
    Configuration menu
    Copy the full SHA
    e524ab4 View commit details
    Browse the repository at this point in the history

Commits on Oct 26, 2022

  1. update syntax.md and JSON schema for metric_group addition

    @jamesmoessis
    jamesmoessis committed Oct 26, 2022
    Configuration menu
    Copy the full SHA
    4a8aabd View commit details
    Browse the repository at this point in the history

Commits on Nov 29, 2022

  1. address comment regarding wording in changelog

    @jamesmoessis
    jamesmoessis committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    9943b8f View commit details
    Browse the repository at this point in the history

Commits on Nov 30, 2022

  1. remove unnecessary 'extends' from test case

    @jamesmoessis
    jamesmoessis committed Nov 30, 2022
    Configuration menu
    Copy the full SHA
    cf47089 View commit details
    Browse the repository at this point in the history

  2. address comments about clarifying and rewording definitions in syntax.md

    @jamesmoessis
    jamesmoessis committed Nov 30, 2022
    Configuration menu
    Copy the full SHA
    086b616 View commit details
    Browse the repository at this point in the history

  3. remove field that stores instrument markdown repr, instead calculate … 

    …while rendering markdown
    @jamesmoessis
    jamesmoessis committed Nov 30, 2022
    Configuration menu
    Copy the full SHA
    9da7198 View commit details
    Browse the repository at this point in the history

  4. appease lint

    @jamesmoessis
    jamesmoessis committed Nov 30, 2022
    Configuration menu
    Copy the full SHA
    cff3949 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' into metrics-semconv

    @jamesmoessis
    jamesmoessis committed Nov 30, 2022
    Configuration menu
    Copy the full SHA
    57d8c4f View commit details
    Browse the repository at this point in the history

Commits on Dec 1, 2022

  1. appease new linter f-string requirements

    @jamesmoessis
    jamesmoessis committed Dec 1, 2022
    Configuration menu
    Copy the full SHA
    fdd98f3 View commit details
    Browse the repository at this point in the history

Commits on Dec 6, 2022

  1. use f-string and inline a variable

    @jamesmoessis
    jamesmoessis committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    0f086b0 View commit details
    Browse the repository at this point in the history

Commits on Jan 19, 2023

  1. Merge branch 'main' into metrics-semconv

    @jamesmoessis
    jamesmoessis committed Jan 19, 2023
    Configuration menu
    Copy the full SHA
    f393d8b View commit details
    Browse the repository at this point in the history