Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve documentation of code generator #198

Closed
joaopgrassi opened this issue Aug 23, 2023 · 8 comments
Closed

Improve documentation of code generator #198

joaopgrassi opened this issue Aug 23, 2023 · 8 comments
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers help wanted Extra attention is needed semconv Related to the semantic convention generator.

Comments

@joaopgrassi
Copy link
Member

There are a couple of issues about our current code generator documentation. In general, I feel the process to get the things working is not clear. There are several arguments that are not documented at all, and folks need either to ask here, or dig into the code themselves to find things out.

I can tell from my own experience as a "first timer". It was particularly painful for me when I was trying to get it to work for the .NET SDK open-telemetry/opentelemetry-dotnet#2069.

I feel we need to cover in the docs:

  • All the parameters the tool accepts and what they do
  • Examples of how to use it to generate code files from YAML
    • Here we could either link to the existing one we know in Java + another language as JS
@joaopgrassi joaopgrassi added documentation Improvements or additions to documentation good first issue Good for newcomers help wanted Extra attention is needed labels Aug 23, 2023
@ezinneanne
Copy link

Hello, can I work on this?

@joaopgrassi
Copy link
Member Author

Hi @ezinneanne sure! Feel free to work on it and reach out if something is unclear.

@joaopgrassi
Copy link
Member Author

@ezinneanne are you working on this? Let me know so I can assign it to you then. Thank you!

@Oberon00 Oberon00 added the semconv Related to the semantic convention generator. label Sep 7, 2023
@ezinneanne
Copy link

Hello, I would love to work on this but am preoccupied at the moment. You can assign it to someone else. Thank you @joaopgrassi

@lmolkova
Copy link
Contributor

I think this was covered in #243 and will be fully merged in #295

@lmolkova
Copy link
Contributor

lmolkova commented Mar 25, 2024

There were a lot of docs improvements in the 0.24.0 release - https://github.com/open-telemetry/build-tools/blob/v0.24.0/semantic-conventions/README.md#code-generator

I think we can still improve it further documenting a few remaining filters and tests, so I'm keeping it open.

@AnushkaShreyam
Copy link

Hi, Can I work on documenting the 0.24.0 release? Let me know...

@lmolkova
Copy link
Contributor

lmolkova commented Oct 9, 2024

closing this issue - we're sunsetting otel/semconvgen in favor of weaver #322 and won't make any improvements here.

@lmolkova lmolkova closed this as completed Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers help wanted Extra attention is needed semconv Related to the semantic convention generator.
Projects
Archived in project
Development

No branches or pull requests

5 participants