Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cardinality attribute property #168

Open
lmolkova opened this issue Apr 24, 2023 · 2 comments
Open

Add cardinality attribute property #168

lmolkova opened this issue Apr 24, 2023 · 2 comments
Labels
enhancement New feature or request semconv/model Related to the data model or YAML format of the semantic convention generator semconv Related to the semantic convention generator.

Comments

@lmolkova
Copy link
Contributor

lmolkova commented Apr 24, 2023 •
edited
Loading

With attributes are reused across signals, it becomes harder to notice when high-cardinality attribute is being referenced from metrics.

Boolean flag could help make it obvious or, potentially, automate checking.

See e.g. open-telemetry/opentelemetry-specification#3355 (comment) for context
@lmolkova lmolkova changed the title Add cardinality flag to attributes Add cardinality attribute property Apr 24, 2023
@lmolkova lmolkova mentioned this issue Apr 24, 2023
Merged
@lmolkova
Copy link
Contributor Author

lmolkova commented Apr 25, 2023 •
edited
Loading

alternative: reuse tag property with the limitation there could only be one tag. E.g. db.connection_string already has one.

@Oberon00 Oberon00 added enhancement New feature or request semconv Related to the semantic convention generator. semconv/model Related to the data model or YAML format of the semantic convention generator labels Apr 25, 2023
@lmolkova
Copy link
Contributor Author

Related: open-telemetry/semantic-conventions#205 (comment)

When defining enum values with custom values allowed, the note description should reflect if low cardinality is required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request semconv/model Related to the data model or YAML format of the semantic convention generator semconv Related to the semantic convention generator.
Projects
Semantic Conventions Tooling
Status: Improve YAML Schema
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Oberon00 @lmolkova