Add default LogicalChannel and ChannelFunction if missing

open-stage · Sep 22, 2024 · 3900df0 · 3900df0
1 parent f81cdcd
commit 3900df0
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/pygdtf/__init__.py b/pygdtf/__init__.py
@@ -972,7 +972,7 @@ def _read_xml(self, xml_node: "Element"):
         self.geometry = xml_node.attrib.get("Geometry")
         self.logical_channels = [
             LogicalChannel(xml_node=i) for i in xml_node.findall("LogicalChannel")
-        ]
+        ] or [LogicalChannel(attribute="NoFunction")]
 
         initial_function_node = xml_node.attrib.get("InitialFunction")
         if initial_function_node:
@@ -1005,7 +1005,9 @@ def __init__(
         if channel_functions is not None:
             self.channel_functions = channel_functions
         else:
-            self.channel_functions = []
+            self.channel_functions = [
+                ChannelFunction(attribute="NoFeature", default=DmxValue("0/1"))
+            ]
         super().__init__(*args, **kwargs)
 
     def _read_xml(self, xml_node: "Element"):
@@ -1016,7 +1018,7 @@ def _read_xml(self, xml_node: "Element"):
         self.dmx_change_time_limit = float(xml_node.attrib.get("DMXChangeTimeLimit", 0))
         self.channel_functions = [
             ChannelFunction(xml_node=i) for i in xml_node.findall("ChannelFunction")
-        ]
+        ] or [ChannelFunction(attribute="NoFeature", default=DmxValue("0/1"))]
 
 
 class ChannelFunction(BaseNode):