Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/Scheduler Framework #99

Merged
merged 13 commits into from
Jul 21, 2024
Merged

Refactor/Scheduler Framework #99

merged 13 commits into from
Jul 21, 2024

Conversation

ishiko732
Copy link
Member

@ishiko732 ishiko732 commented Jul 20, 2024

I refactored the schedulerCard to facilitate the implementation of #98 and #14.

  • replace scheduler:
    image

Copy link

codecov bot commented Jul 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (92c64fd) to head (33ad701).

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #99   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            7         9    +2     
  Lines          375       439   +64     
  Branches        47        50    +3     
=========================================
+ Hits           375       439   +64     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@L-M-Sherlock L-M-Sherlock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ishiko732 ishiko732 merged commit ba57899 into main Jul 21, 2024
5 checks passed
@ishiko732 ishiko732 deleted the refactor branch July 21, 2024 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants