Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade typescript-eslint to version 8 #107

Merged

Conversation

joshdavham
Copy link
Member

@joshdavham joshdavham commented Jul 31, 2024

typescript-eslint v8.0.0 was released today which means that projects (like this one) that have both eslint and typescript-eslint no longer have to deal with peer dependency issues between them. I was previously unable to install the dev dependencies in this project, but updating to v8 fixed that.

Let me know if there are any questions / issues 👍

Copy link
Member

@ishiko732 ishiko732 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ishiko732
Copy link
Member

I need to fix the codecov issue before I can merge.😢
image

Copy link

codecov bot commented Aug 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (2d6e546) to head (5827853).

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #107   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines          553       553           
  Branches        58        58           
=========================================
  Hits           553       553           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ishiko732
Copy link
Member

Great, it's finally fixed!

@ishiko732 ishiko732 merged commit 9f4d08d into open-spaced-repetition:main Aug 1, 2024
5 checks passed
@ishiko732
Copy link
Member

A pnpm-lock.yaml that runs on nodejs 18.20.3 is required, otherwise GitHub Pages cannot be successfully deployed.
image

@joshdavham joshdavham deleted the typescript-eslint-v8 branch August 1, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants