Protect target JsonCpp::JsonCpp against multi-include #1435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Marcus-D-Forte
approved these changes
May 30, 2023
Marcus-D-Forte
approved these changes
Aug 17, 2023
|
Friendly ping. |
|
Is this project maintained? It's not clear to me. |
yes. I think we're intimidated by cmake though :) |
BillyDonahue
approved these changes
Oct 8, 2023
ZigRazor
approved these changes
Apr 16, 2024
|
This is the right way to do this! Any reason this has not been merged? |
JonasVautherin
approved these changes
Aug 20, 2024
|
Recently we were in a situation where the TravisCI integration was broken and caused no patches to get landed. This unfortunately happened for quite some time and I have now resolved it by migrating the repository to GitHub Actions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1356, courtesy of @johnwason