-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Add support for Bazel build system #1275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Not sure why the build is failing, I'm wondering if it is a fluke? |
|
Name conflict. The CI has been building in |
cdunn2001
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're very happy to include support for Bazel. Thank you!
appveyor.yml
Outdated
| # The build script starts in root. | ||
| - set JSONCPP_FOLDER=%cd% | ||
| - set JSONCPP_BUILD_FOLDER=%JSONCPP_FOLDER%\build\release | ||
| - set JSONCPP_BUILD_FOLDER=%JSONCPP_FOLDER%\build_out\release |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why build_out for cmake? Is that to be consistent with a bagel folder?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Name conflict. The CI has been building in
buildfolder, but nowBUILDis a file in the repo.
Anyway, I've removed this change and renamed the Bazel file to BUILD.bazel. This name is less popular, but officialy recognized by Bazel.
README.md
Outdated
| ### The Meson Build System | ||
| If you are using the [Meson Build System](http://mesonbuild.com), then you can get a wrap file by downloading it from [Meson WrapDB](https://wrapdb.mesonbuild.com/jsoncpp), or simply use `meson wrap install jsoncpp`. | ||
|
|
||
| ### The Bazel build system |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to keep README.md short and move as much as possible to our wiki? The reason is simple: To avoid doc-only changes in the source-code repo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed
|
Note to be added to the wiki: The Bazel build systemTo use specific JsonCpp version in your Bazel project, edit your Replace In either case, add |
|
The commits seem to be gone. Rebase maybe? |
|
@cdunn2001 |
|
Copied to wiki. Thanks! |
This reverts commit 375a111.
Adds support for using JsonCpp as an external package in Bazel projects.
Tested in https://github.com/google/verible by replacing:
with:
in
WORKSPACEfile, and then runningbazel clean; bazel test //...