Assign with comments #124
Merged
Assign with comments #124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All tests pass, but we might be missing coverage. issue open-source-parsers#47
* array * double * string * true * false * null
tests pass
cdunn2001
force-pushed
the
assign-with-comments
branch
from
37b8716 to
836f0fb
Compare
`operator=()` (which already performed a deep-copy) now includes comments. The change is probably harmless in all practical cases.
cdunn2001
added a commit
that referenced
this pull request
Jan 20, 2015
1.2.0 `operator=()` (which already performed a deep-copy) now includes comments. This change is probably harmless in all practical cases. But just in case, we bump the minor version. Address #47.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, tests for comments before various types. We might be missing some coverage though.
Addresses #47.