feat: introduce streaming ops and backpressure to prevent OOM #96
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChenZiHong-Gavin
changed the title
…to feature/map-and-all-reduce
Collaborator
Author
|
https://docs.ray.io/en/latest/ maybe better. |
…to feature/map-and-all-reduce
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
Comment on lines
+82
to
+98
| # if not path.exists(): | ||
| # raise FileNotFoundError(f"[Read] input_path not found: {input_file}") | ||
| # | ||
| # if allowed_suffix is None: | ||
| # support_suffix = set(_MAPPING.keys()) | ||
| # else: | ||
| # support_suffix = {s.lower().lstrip(".") for s in allowed_suffix} | ||
| # | ||
| # # single file | ||
| # if path.is_file(): | ||
| # suffix = path.suffix.lstrip(".").lower() | ||
| # if suffix not in support_suffix: | ||
| # logger.warning( | ||
| # "[Read] Skip file %s (suffix '%s' not in allowed_suffix %s)", | ||
| # path, | ||
| # suffix, | ||
| # support_suffix, |
Comment on lines
+108
to
+118
| # for p in path.rglob("*"): | ||
| # if p.is_file() and p.suffix.lstrip(".").lower() in support_suffix: | ||
| # try: | ||
| # suffix = p.suffix.lstrip(".").lower() | ||
| # reader = _build_reader(suffix, cache_dir) | ||
| # logger.info("[Reader] Reading file %s", p) | ||
| # docs = reader.read(str(p)) | ||
| # if docs: | ||
| # yield docs | ||
| # except Exception: # pylint: disable=broad-except | ||
| # logger.exception("[Reader] Error reading %s", p) |
Comment on lines
+1
to
+3
| from ray.data.datasource import ( | ||
| Datasource, ReadTask | ||
| ) |
| from ray.data.datasource import ( | ||
| Datasource, ReadTask | ||
| ) | ||
| import pyarrow as pa |
| Datasource, ReadTask | ||
| ) | ||
| import pyarrow as pa | ||
| from typing import List, Dict, Any, Optional, Union |
| import pyarrow as pa | ||
| from typing import List, Dict, Any, Optional, Union | ||
|
|
||
| from typing import Iterator, List, Optional |
| 'cached_at': time.time() | ||
| }) | ||
| logger.info(f"Cached scan result for: {path}") | ||
| except OSError: |
…to feature/map-and-all-reduce
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the GraphGen engine to a streaming-first architecture with explicit back-pressure, eliminating the long-standing risk of out-of-memory (OOM) crashes when datasets no longer fit in RAM.