feat: Add <@samuelard7> as a contributor #708
Conversation
|
Congratulations on completing the How to Contribute to Open Source chapter of the Intro to Open Source Course with your contribution to this repository, @samuelard7! You're almost to the end of the course. Create a highlight of your contribution to our guestbook using the instructions in the next chapter and share it with us! |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Compliance Checks
Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.
Issue Reference
In order to be considered for merging, the pull request description must refer to a specific issue number. This is described in our Contributing Guide.
This check is looking for a phrase similar to: "Fixes #XYZ" or "Resolves #XYZ" where XYZ is the issue number that this PR is meant to address.
There was a problem hiding this comment.
Congrats on making your first Pull Request and thanks for taking the time to improve Open Sauced! ❤️! 🎉🍕
Say hello by joining the conversation in our Discord
There was a problem hiding this comment.
Hey @samuelard7,
Thank you for your contribution! ✨
However, there are a few things here before we review your PR:
- Please address the warning bot and make sure all check pass.
- You need to add the description of your PR.
- We have merged a PR before yours. Please resolve the merge conflicts by following these instructions in our course before we can review your PR.
Let me know if you have questions or need any help. 😊
samuelard7
changed the title
samuelard7
changed the title
There was a problem hiding this comment.
Hi @samuelard7,
I left some comments for you to fix. My concerns here:
- I'm not sure why there are
feat/add-richardandmainall over the place. - There is no closing brackets between your profile and other contributor's in the
.all-contributorsrcfile. If you run the command to generate the profile, this will actually break the README.
Please follow the instructions in our course to resolve the merge conflicts.
If you're unsure how to fix, you can always close this PR and create a new one.
Thank you.🙂
| @@ -3755,6 +3755,44 @@ | |||
| ] | |||
| }, | |||
| { | |||
| feat/add-richard | |||
There was a problem hiding this comment.
I'm not sure why this is here. Can you please remove it?
| "translation", | ||
| "tutorial", | ||
| "userTesting", | ||
| "video" |
There was a problem hiding this comment.
This should have a closing brackets.
| "video" | |
| "video" | |
| ] | |
| } |
| main | ||
| ] | ||
| } |
There was a problem hiding this comment.
There shouldn't be a main here. Please remove it.
| feat/add-richard | ||
|
|
||
|
|
||
| main |
There was a problem hiding this comment.
- After solving the merge conflicts and run the command to generate profile, the badge should increase. But this hasn't increased.
- These lines of code are not supposed to be here. Please remove them.
| <td align="center" valign="top" width="14.28%"><a href="https://github.com/sultanovich"><img src="https://avatars.githubusercontent.com/u/601474?v=4?s=100" width="100px;" alt="Pablo"/><br /><sub><b>Pablo</b></sub></a><br /><a href="#question-sultanovich" title="Answering Questions">💬</a> <a href="#blog-sultanovich" title="Blogposts">📝</a> <a href="https://github.com/TejasQ/opensauced-guestbook/issues?q=author%3Asultanovich" title="Bug reports">🐛</a> <a href="https://github.com/TejasQ/opensauced-guestbook/commits?author=sultanovich" title="Code">💻</a> <a href="https://github.com/TejasQ/opensauced-guestbook/commits?author=sultanovich" title="Documentation">📖</a> <a href="#infra-sultanovich" title="Infrastructure (Hosting, Build-Tools, etc)">🚇</a> <a href="#maintenance-sultanovich" title="Maintenance">🚧</a> <a href="#mentoring-sultanovich" title="Mentoring">🧑🏫</a> <a href="https://github.com/TejasQ/opensauced-guestbook/pulls?q=is%3Apr+reviewed-by%3Asultanovich" title="Reviewed Pull Requests">👀</a> <a href="#security-sultanovich" title="Security">🛡️</a></td> | ||
| </tr> | ||
| main |
There was a problem hiding this comment.
This main should not be here. Please remove it.
| @@ -383,8 +386,13 @@ Thanks goes to these wonderful people ([emoji key](https://allcontributors.org/d | |||
| <tr> | |||
| <td align="center" valign="top" width="14.28%"><a href="https://github.com/Spcxx"><img src="https://avatars.githubusercontent.com/u/28925424?v=4?s=100" width="100px;" alt="Spc"/><br /><sub><b>Spc</b></sub></a><br /><a href="#question-Spcxx" title="Answering Questions">💬</a> <a href="https://github.com/TejasQ/opensauced-guestbook/issues?q=author%3ASpcxx" title="Bug reports">🐛</a> <a href="https://github.com/TejasQ/opensauced-guestbook/commits?author=Spcxx" title="Code">💻</a> <a href="https://github.com/TejasQ/opensauced-guestbook/commits?author=Spcxx" title="Documentation">📖</a> <a href="#ideas-Spcxx" title="Ideas, Planning, & Feedback">🤔</a> <a href="#translation-Spcxx" title="Translation">🌍</a></td> | |||
| <td align="center" valign="top" width="14.28%"><a href="https://github.com/crow50"><img src="https://avatars.githubusercontent.com/u/15437063?v=4?s=100" width="100px;" alt="Ernest Baker"/><br /><sub><b>Ernest Baker</b></sub></a><br /><a href="#question-crow50" title="Answering Questions">💬</a> <a href="#blog-crow50" title="Blogposts">📝</a> <a href="https://github.com/TejasQ/opensauced-guestbook/issues?q=author%3Acrow50" title="Bug reports">🐛</a> <a href="#business-crow50" title="Business development">💼</a> <a href="https://github.com/TejasQ/opensauced-guestbook/commits?author=crow50" title="Code">💻</a> <a href="#data-crow50" title="Data">🔣</a> <a href="https://github.com/TejasQ/opensauced-guestbook/commits?author=crow50" title="Documentation">📖</a> <a href="#ideas-crow50" title="Ideas, Planning, & Feedback">🤔</a> <a href="#infra-crow50" title="Infrastructure (Hosting, Build-Tools, etc)">🚇</a> <a href="#maintenance-crow50" title="Maintenance">🚧</a> <a href="#platform-crow50" title="Packaging/porting to new platform">📦</a> <a href="#plugin-crow50" title="Plugin/utility libraries">🔌</a> <a href="https://github.com/TejasQ/opensauced-guestbook/pulls?q=is%3Apr+reviewed-by%3Acrow50" title="Reviewed Pull Requests">👀</a> <a href="#security-crow50" title="Security">🛡️</a> <a href="https://github.com/TejasQ/opensauced-guestbook/commits?author=crow50" title="Tests">⚠️</a> <a href="#tool-crow50" title="Tools">🔧</a> <a href="#tutorial-crow50" title="Tutorials">✅</a></td> | |||
| feat/add-richard | |||
There was a problem hiding this comment.
This not supposed to be here. Please remove it.
Description
PR to add @samuelard7 as a contributor
What type of PR is this? (check all applicable)
Related Issues
Contributors Checklist
I've read through the Getting Started section
Have you run
npm run contributors:generateto generate your profile and the badge on the README?Added to documentation?
Screenshot (Required for PR Review)
[optional] What GIF best describes this PR or how it makes you feel?