Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat 3960 kotlin send message function #157

Open
wants to merge 28 commits into
base: main
Choose a base branch
from
Open

Feat 3960 kotlin send message function #157

wants to merge 28 commits into from

Conversation

ArtP1
Copy link

@ArtP1 ArtP1 commented Jul 13, 2023

Co-authored by @jamesrcramos & @softTam

What does this PR do?

This PR adds a new Kotlin cloud function, called sendMessage(), to the Open Runtimes Examples repository.

The features will include:

  1. The ability to send messages to a recipient using Email, SMS, Discord, and Twitter.

Test Plan

Manual executions using cURL commands:

  1. SMS
    Twillio cURL
    SMS

  2. Mail
    Mail cURL
    Mail

  3. Discord
    Discord cURL
    Discord

  4. Twitter
    Twitter cURL
    Twitter

Related PRs and Issues

⚡ Write a sendMessage() Function using Kotlin #3960

Checklist

  • Ask to be assigned to the issue.
  • Implement function sendMessage() in Kotlin/ folder.
  • Manually execute the newly implemented function to ensure it works.
  • Submit a pull request in open-runtimes/examples and include screenshots of successful execution.

softTam and others added 27 commits June 30, 2023 17:32
@softTam
Added sendMessage in Kotlin folder
050b01a
@jamesrcramos
Added function headers to Index.kt file
d396222
@softTam
Added main function, no input validator
1f00f03
@softTam
Resolved merge conflict
ebdbafe
@softTam
Fixed syntax errors; working main and helper fnctions
af23ab6
@softTam
Added sendMessageDiscordWebhook function
a34f702
@jamesrcramos
Added unfinished sendEmailMailgun.kt file; troubleshoot authenticatio…
5d0b5ac 
…n to complete
@jamesrcramos
Merged to catch up to codebase
815e068
@ArtP1
Added sendMessageSMS kotlin file; in progress
7a60348
@ArtP1
Added sendMessageTwitter kotlin file; in progress
cbc5ec5
@ArtP1
Completed sendMessageSMS & error handling on main
a99371c
@jamesrcramos
Created working version of Mailgun implementation
51fdeb1
@jamesrcramos
Improved function formatting and return statements
c3feaff
@softTam
Draft. Commit for the purpose of pulling from origin
c5e7e39
@softTam
Merge branch 'feat-3960-kotlin-sendMessage-function' of https://githu…
816c20e 
…b.com/ArtP1/examples into feat-3960-kotlin-sendMessage-function
@jamesrcramos
Moved sendEmail function to Index.kt and minor syntax improvements an…
94ba8bd 
…d fixes
@softTam
Added sendTweet. Got 401 - Unauthorized error.
d4dca46
@softTam
Combined all functions into Index.kt. Deleted all helper files.
301e757
@softTam
Deleted all helper files.
6818141
@jamesrcramos
Removed messages from return statements
b535124
@ArtP1
Added READ.me file
5344941
@softTam
Suncessfully implemented sendTweet() function
d83e346
@softTam
Added input validation for sendTweet. Cleaned up comments.
83b360c
@softTam
Updated README.md file with Twitter option.
59e13fd
@softTam
Added more input validation. Ensured consistency in stylyes. Moved In…
562a787 
…dex.kt into src folder.
@ArtP1
Fixed READ.me file
5fdca32
@ArtP1
Fix: wrong path declared in READ.me file
57c23b1
@stnguyen90 stnguyen90 self-requested a review July 21, 2023 17:56
stnguyen90
stnguyen90 approved these changes Jul 25, 2023
View reviewed changes
Copy link
Contributor

@stnguyen90 stnguyen90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey 👋 awesome work on your PR! We've approved your work and it'll be merged soon!

kotlin/sendMessage/src/Index.kt Outdated Show resolved Hide resolved
@stnguyen90 stnguyen90 requested a review from Meldiron July 25, 2023 23:03
@ArtP1
Minimized the number of newlines
0e251e1 
* Index.kt
* README.md
@github-actions github-actions bot mentioned this pull request Aug 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hemalHD hemalHD hemalHD approved these changes

@stnguyen90 stnguyen90 stnguyen90 approved these changes

@Meldiron Meldiron Awaiting requested review from Meldiron

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ArtP1 @stnguyen90 @hemalHD @softTam @jamesrcramos