Merge pull request #895 from amanusk/fix/parse_notifications

fix: parse notifications
open-rpc · Jun 27, 2024 · 86805d8 · 86805d8
2 parents c6ddc64 + 7c81f67
commit 86805d8
Show file tree

Hide file tree

Showing 2 changed files with 27 additions and 3 deletions.
diff --git a/src/dereference-document.ts b/src/dereference-document.ts
@@ -143,7 +143,9 @@ const handleMethod = async (methodOrRef: MethodOrReference, doc: OpenrpcDocument
   }
 
   method.params = await derefItems(method.params as ReferenceObject[], doc, resolver);
-  method.result = await derefItem(method.result as ReferenceObject, doc, resolver);
+  if (method.result !== undefined) {
+    method.result = await derefItem(method.result as ReferenceObject, doc, resolver);
+  }
 
 
   let componentSchemas: SchemaComponents = {};
@@ -157,8 +159,10 @@ const handleMethod = async (methodOrRef: MethodOrReference, doc: OpenrpcDocument
     p.schema = await handleSchemaWithSchemaComponents(p.schema, componentSchemas);
   }
 
-  const result = method.result as ContentDescriptorObject;
-  result.schema = await handleSchemaWithSchemaComponents(result.schema, componentSchemas);
+  if (method.result !== undefined) {
+    const result = method.result as ContentDescriptorObject;
+    result.schema = await handleSchemaWithSchemaComponents(result.schema, componentSchemas);
+  }
 
   return method;
 };

diff --git a/src/parse-open-rpc-document.test.ts b/src/parse-open-rpc-document.test.ts
@@ -24,6 +24,20 @@ const workingDocument: OpenRPC = {
   openrpc: "1.0.0-rc1",
 };
 
+const notificationDocument: OpenRPC = {
+  ...workingDocument,
+  methods: [
+    {
+      name: "foo",
+      params: [
+        {
+          name: "bar",
+          schema: { "type": "boolean" },
+        },
+      ],
+    },
+  ],
+};
 const badRefDocument: OpenRPC = {
   ...workingDocument,
   methods: [
@@ -101,6 +115,12 @@ describe("parseOpenRPCDocument", () => {
     expect(document.methods).toBeDefined();
   });
 
+  it("handles being passed an open rpc object with notification", async () => {
+    expect.assertions(1);
+    const document = await parseOpenRPCDocument(notificationDocument);
+    expect(document.methods).toBeDefined();
+  });
+
   it("can disable validation", async () => {
     expect.assertions(1);
     const document = await parseOpenRPCDocument(invalidDocument, { validate: false });