Signature scheme datasheets #1053
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dstebila
approved these changes
Jul 22, 2021
|
Thanks Goutam! Merge whenever you're ready. |
Martyrshot
pushed a commit
to Martyrshot/liboqs
that referenced
this pull request
Jul 27, 2021
dstebila
added a commit
that referenced
this pull request
Jul 30, 2021
* sha256 cyrpto extensions seem to work, want to add neon version if crypto isn't available * Added additional files to CMakeLists.txt * SHA256 armv8 implementation is done. Still need to double check that everything is happen when complied on a non-arm system, and an arm system that doesn't have the cyrpto extensions * Updated sha2 CMakeList.txt to resolve issue compiling on aws ARM system * I think I have resolved the aws/rock1 build issues * Removed an resolved TODO comment * Fixed a cmake build bug when OQS_DIST_BUILD is "ON" * Made CMAKE sha2 build more flexible when using OQS_DIST_BUILD * Signature datasheets (#1053). * Fixed a typo in the common CMakeLists.txt file related to SHA2 * Add runtime feature detection for macOS on Apple Silicon * Changed macos_feature_detection to return unsigned int to fix warnings, and updated some uint32_t to const uint32_t to fix warnings on macOS on Apple silicon Co-authored-by: Goutam Tamvada <xvzcf@users.noreply.github.com> Co-authored-by: Douglas Stebila <dstebila@uwaterloo.ca>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.