Optimize pom.xml & Some fixes#25
Merged
Merged
Conversation
Contributor
Author
|
Output when Output after configuration: |
xybei
changed the title
Signed-off-by: xybei <xybei@outlook.com>
Signed-off-by: xybei <xybei@outlook.com>
1. Output native library to ${project.build.outputDirectory}, avoid using "${basedir}/src/main/resources/" and file copying.
2. Use <linkerFinalName> and <linkerFinalNameExt> to specify the output library name, otherwise invalid link instructions will be added:
'-o/mnt/d/OpenSource/liboqs-java/target/classes/liboqs-java.jar'
Signed-off-by: xybei <xybei@outlook.com>
Signed-off-by: xybei <xybei@outlook.com>
jimouris
reviewed
Aug 20, 2024
Member
There was a problem hiding this comment.
Apologies for the super delayed response, I somehow had missed this. I see you have removed:
- maven-compiler-plugin
- maven-jar-plugin
- maven-antrun-plugin
- maven-resources-plugin
Are those not needed?
Also JNI_COMMIT has been changed to 0, does this solve the memory leak problem?
jimouris
approved these changes
Aug 20, 2024
Member
jimouris
left a comment
jimouris
left a comment
There was a problem hiding this comment.
Looks great, thanks for contributing!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
3.1. Output native library to
${project.build.outputDirectory}, avoid using"${basedir}/src/main/resources/"and file copying.3.2. Use
<linkerFinalName>and<linkerFinalNameExt>to specify the output library name, otherwise invalid link instructions will be added:'-o/mnt/d/OpenSource/liboqs-java/target/classes/liboqs-java.jar'For the
ReleaseByteArrayElements()function, if themodeparameter isJNI_COMMIT, it will cause memory leak.JNI_COMMIT: copy back the content but do not free the elems buffer.0: copy back the content and free the elems buffer.But there is no macro definition of
0injni.h.