forked from torvalds/linux
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
systemtap: not to use spin_unlock_wait anymore #21
Comments
mopsfelder
added a commit
to mopsfelder/versions
that referenced
this issue
Oct 31, 2017
This updates systemtap.spec to version 3.2 and dependencies of open-power-host-os.spec. Fix open-power-host-os/linux#21
mopsfelder
added a commit
to mopsfelder/versions
that referenced
this issue
Oct 31, 2017
This updates systemtap.spec to version 3.2 and dependencies of open-power-host-os.spec. Fix open-power-host-os/linux#21 (cherry picked from commit 3975da8)
This was referenced Oct 31, 2017
I confirm that systemtap-3.2-1.dev.git4051c70.el7.centos.ppc64le is working fine with kernel-4.14.0-2.rc8.dev.gitcc4bf22.el7.centos.ppc64le. This issue can be closed.
|
liyi-ibm
referenced
this issue
in liyi-ibm/linux
Dec 6, 2018
pid_task() dereferences rcu protected tasks array. But there is no rcu_read_lock() in shutdown_umh() routine so that rcu_read_lock() is needed. get_pid_task() is wrapper function of pid_task. it holds rcu_read_lock() then calls pid_task(). if task isn't NULL, it increases reference count of task. test commands: %modprobe bpfilter %modprobe -rv bpfilter splat looks like: [15102.030932] ============================= [15102.030957] WARNING: suspicious RCU usage [15102.030985] 4.19.0-rc7+ #21 Not tainted [15102.031010] ----------------------------- [15102.031038] kernel/pid.c:330 suspicious rcu_dereference_check() usage! [15102.031063] other info that might help us debug this: [15102.031332] rcu_scheduler_active = 2, debug_locks = 1 [15102.031363] 1 lock held by modprobe/1570: [15102.031389] #0: 00000000580ef2b0 (bpfilter_lock){+.+.}, at: stop_umh+0x13/0x52 [bpfilter] [15102.031552] stack backtrace: [15102.031583] CPU: 1 PID: 1570 Comm: modprobe Not tainted 4.19.0-rc7+ #21 [15102.031607] Hardware name: To be filled by O.E.M. To be filled by O.E.M./Aptio CRB, BIOS 5.6.5 07/08/2015 [15102.031628] Call Trace: [15102.031676] dump_stack+0xc9/0x16b [15102.031723] ? show_regs_print_info+0x5/0x5 [15102.031801] ? lockdep_rcu_suspicious+0x117/0x160 [15102.031855] pid_task+0x134/0x160 [15102.031900] ? find_vpid+0xf0/0xf0 [15102.032017] shutdown_umh.constprop.1+0x1e/0x53 [bpfilter] [15102.032055] stop_umh+0x46/0x52 [bpfilter] [15102.032092] __x64_sys_delete_module+0x47e/0x570 [ ... ] Fixes: d2ba09c ("net: add skeleton of bpfilter kernel module") Signed-off-by: Taehee Yoo <ap420073@gmail.com> Acked-by: Alexei Starovoitov <ast@kernel.org> Signed-off-by: David S. Miller <davem@davemloft.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
cde:info Mirrored with LTC bug https://bugzilla.linux.ibm.com/show_bug.cgi?id=160774 </cde:info>
Systemtap (3.1-5.dev.git39b62b4) seems to be broken in current hostos devel (4.14 rc4 kernel) for a reason that it refers to calling spin_unlock_wait() which is no more in kernel as in its commit d3a024a
Hence, executing systemtap ends up with below error:
Upstream systemtap fix to getrid of spin_unlock_wait:
https://sourceware.org/git/gitweb.cgi?p=systemtap.git;a=commit;f=runtime/stp_utrace.c;h=0643ca2b7fd8cb6407aa84f41d26a71d2f2f8e90
Applied fix locally With that,
Tried wiping out ~/.systemtap/cache/ but did not help. So, matched /usr/src/kernels/.../include/generated/compile.h, for stap and it worked (just a workaround to avoid recompiling stap).
Please include mentioned patch for systemtap to work.
The text was updated successfully, but these errors were encountered: