Support static binary versions #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @bryannaegele, thanks for this. It makes sense and is a good option to support. Would you be able to sign off your commit so that the DCO check completes? We have some docs on the matter here: https://www.openpolicyagent.org/docs/latest/contrib-code/#developer-certificate-of-origin |
Signed-off-by: Bryan Naegele <bryan@simplebet.io>
|
Done! First time I've seen that used. |
|
Thanks @bryannaegele this is great! It looks like one of the packages needs to be updated to fix the one test failure, I'll do that in a separate pr. |
tim775
approved these changes
Jun 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for downloading the static version of the binaries which is needed to run on arm architectures which don't have a non-static binary available, such as opa_linux_arm64_static. This is especially helpful for testing workflows locally with act on apple silicon.
Fixes #15