download: fix ignored OCI downloader settings - #9113
Open
sspaink wants to merge 1 commit into
Open
Conversation
Running the unused linter with field-writes-are-uses set to false, which is not enabled in .golangci.yaml, flags five fields in this package that are only ever written. Two of them are real bugs. OCIDownloader.WithSizeLimitBytes and WithBundlePersistence stored their arguments in fields download() never read, so size_limit_bytes went unenforced for OCI bundle sources and the reader's guard on persisted delta bundles could never fire. Wire both through as Downloader does. The rest are dead: the trigger channel on both downloaders, unused since Trigger() calls oneShot directly, and Downloader.stopped, dead since Stop() moved to sync.Once. TestStopWithMultipleCalls asserted on the latter, a check that could not fail; it now asserts the Stop calls return, the deadlock it guards. Signed-off-by: Sebastian Spaink <sebastianspaink@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Running the unused linter with field-writes-are-uses set to false, which is not enabled in .golangci.yaml, flags five fields in this package that are only ever written. Two of them are real bugs.
OCIDownloader.WithSizeLimitBytes and WithBundlePersistence stored their arguments in fields download() never read, so size_limit_bytes went unenforced for OCI bundle sources and the reader's guard on persisted delta bundles could never fire. Wire both through as Downloader does.
The rest are dead: the trigger channel on both downloaders, unused since Trigger() calls oneShot directly, and Downloader.stopped, dead since Stop() moved to sync.Once. TestStopWithMultipleCalls asserted on the latter, a check that could not fail; it now asserts the Stop calls return, the deadlock it guards.